Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gfortran: fix darwin build on hydra #42523

Merged
merged 1 commit into from Jun 24, 2018
Merged

gfortran: fix darwin build on hydra #42523

merged 1 commit into from Jun 24, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jun 24, 2018 •
edited

Motivation for this change

All the warnings about unused -isystem arguments causes the build log to
exceed the hydra limit.

https://hydra.nixos.org/build/76372870

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • macOS
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
gfortran: fix darwin build on hydra
222524b 
All the warnings about unused -isystem arguments causes the build log to
exceed the hydra limit.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gfortran

Partial log (click to expand)

these paths will be fetched (33.40 MiB download, 146.03 MiB unpacked):
  /nix/store/40n3swazxkg0swyv4k889d3gwjbaiyyk-gfortran-wrapper-7.3.0
  /nix/store/f7ip2qyvw6g6h3hldj6gipvfga2mayw0-isl-0.17.1
  /nix/store/v20qmizvcgbqf8i5qihrfb3zgh92n3kw-libmpc-1.1.0
  /nix/store/v5rpxrp4gd0g9c5pydps9wc285xkygbk-gfortran-7.3.0
copying path '/nix/store/f7ip2qyvw6g6h3hldj6gipvfga2mayw0-isl-0.17.1' from 'https://cache.nixos.org'...
copying path '/nix/store/v20qmizvcgbqf8i5qihrfb3zgh92n3kw-libmpc-1.1.0' from 'https://cache.nixos.org'...
copying path '/nix/store/v5rpxrp4gd0g9c5pydps9wc285xkygbk-gfortran-7.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/40n3swazxkg0swyv4k889d3gwjbaiyyk-gfortran-wrapper-7.3.0' from 'https://cache.nixos.org'...
/nix/store/40n3swazxkg0swyv4k889d3gwjbaiyyk-gfortran-wrapper-7.3.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gfortran

Partial log (click to expand)

these paths will be fetched (26.91 MiB download, 120.68 MiB unpacked):
  /nix/store/7d8lyc9fkz4z09lwnsb8psqg0ryw1b9z-gfortran-7.3.0
  /nix/store/bhwkg92fbgcqv6hqxbcblvaxkkbcqsr5-gfortran-wrapper-7.3.0
  /nix/store/prfa9kmfqffr325gg60hhnpmizb86l7j-gfortran-7.3.0-lib
  /nix/store/xhba18y9yrnwivcf2bgp0d6wa8b9xj5v-isl-0.17.1
copying path '/nix/store/xhba18y9yrnwivcf2bgp0d6wa8b9xj5v-isl-0.17.1' from 'https://cache.nixos.org'...
copying path '/nix/store/prfa9kmfqffr325gg60hhnpmizb86l7j-gfortran-7.3.0-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/7d8lyc9fkz4z09lwnsb8psqg0ryw1b9z-gfortran-7.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/bhwkg92fbgcqv6hqxbcblvaxkkbcqsr5-gfortran-wrapper-7.3.0' from 'https://cache.nixos.org'...
/nix/store/bhwkg92fbgcqv6hqxbcblvaxkkbcqsr5-gfortran-wrapper-7.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gfortran

Partial log (click to expand)

these derivations will be built:
  /nix/store/j4sqvcpz13v8anrygg16rpklhx7njsj7-gfortran-7.3.0.drv
  /nix/store/j3f77md132hvwnsm6kfw732p8i5w8y7j-gfortran-wrapper-7.3.0.drv
waiting for locks or build slots...
/nix/store/1amqnm1g8088dj1nn349x75pdbwff99h-gfortran-wrapper-7.3.0

@LnL7 LnL7 merged commit 4817afb into NixOS:master Jun 24, 2018
@LnL7 LnL7 deleted the clang-gfortran branch June 24, 2018 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @GrahamcOfBorg @matthewbauer