Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ksonnet: init at v0.11.0 #42596

Closed
wants to merge 1 commit into from
Closed

Conversation

colemickens
Copy link
Member

Motivation for this change

We already have kubecfg from @bentley, this adds ksonnet as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

goPackagePath = "github.com/ksonnet/ksonnet";

meta = {
description = "A CLI-supported framework that streamlines writing and deployment of Kubernetes configurations to multiple clusters. ";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No dot and space at the end of the line

@@ -0,0 +1,24 @@
{ lib, buildGoPackage, fetchFromGitHub, ... }:

let version = "0.11.0"; in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally put the version attribute inside of the derivation and use a recursive attribute set (rec keyword).

@flokli flokli mentioned this pull request Jul 16, 2018
9 tasks
@nlewo
Copy link
Member

nlewo commented Jul 17, 2018

Will be closed in favor of #43644

flokli added a commit to flokli/nixpkgs that referenced this pull request Jul 17, 2018
@nlewo
Copy link
Member

nlewo commented Jul 17, 2018

Closed in favor of #43644.
Thanks.

@nlewo nlewo closed this Jul 17, 2018
@colemickens colemickens deleted the ksonnet branch September 2, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants