Don't define to_json
and self.from_json
on Object
#6275
Closed
+95
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5695
As the title says, this removes
to_json
andself.from_json
fromObject
and moves it toJSON::Serializable
. For the class method (self.from_json
) I had to define a module that gets extened on inclusion.Then,
JSON::Serializable
is included on primitive types,Hash
,Array
,Set
, etc. They of course override theto_json
andself.from_json
methods.In that way, you can't invoke
to_json
on a method and get a strange compile error saying "undefined methodto_json(io)
", now you'll get a better error sayingundefined method
to_json`".You could also check if a type
is_a?(JSON::Serializable)
orresponds_to?(:to_json)
, and so on.If this direction is accepted, I can later add another commit with the same change for YAML.