-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove singular names like Int#day, Int#month, etc. #6273
Remove singular names like Int#day, Int#month, etc. #6273
Conversation
c138f43
to
9448705
Compare
@RX14 what's wrong? |
9448705
to
016e9d3
Compare
Where was it decided? It was just @oprypin stating his PoV... |
@Sija His PR was approved, which means it was agreed to take that direction. Otherwise it wouldn't have been approved. I'm just following the flow here. |
His PR was unrelated and the mentioned comment I'd call a musings on the subject. |
Well, they are aliases, and we don't like aliases, so... |
Yeah, and we shouldn't like obsession too. Wouldn't you like to tackle something that actually matters, instead of nit-picking some random would-be issues? I'm against aliases too but in this case IMO they help more in natural code writing than not. |
Like what? Also, I'm not seeing your PRs tackling things that matter 😅
I agree. If that's the case, someone please send a PR to remove those |
Let's calm down guys. Remember: MINSWAN. Please keep the discussion about arguments and not attacking each other. ❤️ |
The only reason the aliases exist is because we say Either we allow all these aliases, so source code reads better, or we disallow all aliases and keep a single form, which is more consistent. I'm fine with either. |
Like single-msqueue branch for instance.
Fair 'nuff 😅 Take my apologies if you felt offended, that wasn't my intention. |
Oh, but that's too hard to implement and I don't have the knowledge nor the time (also remember I don't get any of the money from bountysource, so Im doing this just for fun, just like you all). And sorry too, my reply came a bit harsh. |
Why closing @asterite ? |
Because it's not decided what to do, and discussing things in a PR is not the way to do it. |
It seems in #5093 (comment) it was decided to remove these aliases. At that time they were marked as
:nodoc:
, not sure why, but it's better to remove them as soon as possible.