Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qiskit: fix build #42606

Merged
merged 1 commit into from Jun 26, 2018
Merged

qiskit: fix build #42606

merged 1 commit into from Jun 26, 2018

Conversation

pandaman64
Copy link
Contributor

Motivation for this change

Fixed build error of QISKit

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@pandaman64 pandaman64 requested a review from FRidh as a code owner June 26, 2018 07:59
@FRidh
Copy link
Member

FRidh commented Jun 26, 2018

And it also still functions properly with the newer versions?

@pandaman64
Copy link
Contributor Author

Yes! I succeeded to run quantum programs on IBM's bleeding-edge quantum computer via this version.

@FRidh
Copy link
Member

FRidh commented Jun 26, 2018

Did you inform upstream that their constraints are not needed?

@FRidh FRidh merged commit fc66a3d into NixOS:master Jun 26, 2018
@pandaman64
Copy link
Contributor Author

Not yet. Are there any documents that state Nixpkgs' single-version policy?

@FRidh
Copy link
Member

FRidh commented Jun 26, 2018

Not that I am aware of. While technically it is possible to maintain multiple versions, we do not because of maintenance.

@pandaman64
Copy link
Contributor Author

I see. I'll open an issue for that later.

@pandaman64
Copy link
Contributor Author

They have already removed the upper bound.
We won't need the patch anymore from the next release.

@pandaman64 pandaman64 deleted the qiskit branch February 19, 2019 13:55
@pandaman64 pandaman64 restored the qiskit branch February 19, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pandaman64 @FRidh @GrahamcOfBorg