Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add saml2aws package #42605

Merged
merged 1 commit into from Jun 29, 2018
Merged

Add saml2aws package #42605

merged 1 commit into from Jun 29, 2018

Conversation

pmyjavec
Copy link

@pmyjavec pmyjavec commented Jun 26, 2018 •
edited

Motivation for this change

Adds a new package, saml2aws, a CLI tool for managaing AWS logins via
SAML. For more information see https://github.com/Versent/saml2aws.

Things done
  • Add nix expression to build the package.
  • Add myself as a maintainer.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

adisbladis
adisbladis reviewed Jun 26, 2018
View reviewed changes
pkgs/tools/security/saml2aws/default.nix Outdated
buildGoPackage rec {
name = "saml2aws-${version}";
version = "2.6.1";
rev = "v${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rev does not need to be an attribute of the derivation, only on the src.

saml2aws: init at 2.6.1
57183ee 
Adds a new package, saml2aws, a CLI tool for managaing AWS logins via
SAML. For more information see https://github.com/Versent/saml2aws.

* Add nix expression to build the package.
* Add myself as a maintainer.
@pmyjavec
Copy link
Author

Thank you @adisbladis, I've amended the commit.

@matthewbauer matthewbauer merged commit c29df03 into NixOS:master Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pmyjavec @adisbladis @matthewbauer @GrahamcOfBorg @Janik-Haag