Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3: 3.6 -> 3.7 #42777

Closed
wants to merge 1 commit into from
Closed

python3: 3.6 -> 3.7 #42777

wants to merge 1 commit into from

Conversation

dirn
Copy link
Contributor

@dirn dirn commented Jun 29, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji xeji requested a review from FRidh June 29, 2018 20:22
@pSub pSub changed the base branch from master to staging July 2, 2018 16:24
@pSub
Copy link
Member

pSub commented Jul 2, 2018

I changed the base to staging as this is a mass-rebuilt.

@dirn
Copy link
Contributor Author

dirn commented Jul 2, 2018

Thanks. Let me know if there are any additional changes that need to be made.

@dotlambda
Copy link
Member

We'll still have to wait quite some time until upstream maintainers have made their packages Python 3.7-compatible.

@LnL7 LnL7 mentioned this pull request Jul 3, 2018
Merged
9 tasks
@FRidh
Copy link
Member

FRidh commented Jul 7, 2018

We won't make this change until 19.03 because there is not enough package compatibility yet.

Note I'm away on holidays and may be unresponsive. Tuesday I should be back.

@FRidh FRidh closed this Jul 7, 2018
@orivej
Copy link
Contributor

orivej commented Jul 7, 2018

I don't need Python 3.7, but I'd like to know: what incompatibilities are there to fix for python package developers? How many packages need to be updated?

@dotlambda
Copy link
Member

I don'y have any numbers, but I tried compiling some stuff once and e.g. found an incompatibility in SQLAlchemy, whis is one of the bigger players: https://bitbucket.org/zzzeek/sqlalchemy/issues/4291/test-failures-with-python-37
PyYAML also comes to mind: yaml/pyyaml#193.
I think there are many more examples, these are just two major ones I came across when testing packages I frequently use.

@orivej
Copy link
Contributor

orivej commented Jul 7, 2018

OK, so pyyaml breaks because it ships a .c file generated by an old Cython, and sqlalchemy tests break because Python 3.7 generates a deprecation warning for inspect.formatargspec. Such issues may affect just a few packages.

@dirn
Copy link
Contributor Author

dirn commented Jul 7, 2018

On the bright side PyYAML seems to be fixed. yaml/pyyaml#193 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dirn @pSub @dotlambda @FRidh @orivej @GrahamcOfBorg