Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix packages broken by python-dateutil bump #42782

Merged
merged 5 commits into from Jun 29, 2018
Merged

Fix packages broken by python-dateutil bump #42782

merged 5 commits into from Jun 29, 2018

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jun 29, 2018 •
edited

Motivation for this change

All these applications are broken due to skarim/vobject#112.
For khal, there is also pimutils/khal#780.

An alternative would be to apply skarim/vobject#115 to the vobject package.

Note that papis doesn't build because pytest-httpbin is broken.
Also, I did not fix all applications that depend on vobject.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda mentioned this pull request Jun 29, 2018
Merged
8 tasks
python.pkgs.pytest-httpbin: disable tests
9ebfa7b 
Tests are not included in the PyPI tarball.
@dotlambda dotlambda requested a review from FRidh as a code owner June 29, 2018 17:42
@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: khal, papis, radicale

Partial log (click to expand)

  File "/nix/store/kbbs63q56ws0jch897yjp3cxg3z9c1xy-python3.6-pytest-3.6.2/lib/python3.6/site-packages/_pytest/fixtures.py", line 900, in __call__
    "fixture is being applied more than once to the same function"
ValueError: fixture is being applied more than once to the same function
ERROR: could not load /build/source/tests/conftest.py

builder for '/nix/store/lrvgdgiqcy9irh8l8m1h4062a60k7m9g-python3.6-pytest-httpbin-0.3.0.drv' failed with exit code 4
cannot build derivation '/nix/store/yfn9zfayyyki5b5a4wb22j607pv3bnyn-python3.6-vcrpy-1.12.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/785ivycqbggcrq1r3i1zcs1ldphbizpm-python3.6-habanero-0.6.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/w6mf4sj3fw01rxq6bzih0s3s2zrg97yv-papis-0.5.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/w6mf4sj3fw01rxq6bzih0s3s2zrg97yv-papis-0.5.3.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: khal, papis, radicale

Partial log (click to expand)

  --vim       Vim based UI
sync
usage: papis sync [-h]

optional arguments:
  -h, --help  show this help message and exit
zotero/test_zotero.sh
/nix/store/x01ivbzkhxdk0ss80y234fc15h9w6m63-khal-0.9.9
/nix/store/qyvdlkjqg1fk2jy8sm7jjxw0nbyy0dpa-papis-0.5.3
/nix/store/va2xvbngvbbjykkq73z851f3n2mx1msr-radicale-2.1.9

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: khal, papis, radicale

Partial log (click to expand)

  --vim       Vim based UI
sync
usage: papis sync [-h]

optional arguments:
  -h, --help  show this help message and exit
zotero/test_zotero.sh
/nix/store/x01ivbzkhxdk0ss80y234fc15h9w6m63-khal-0.9.9
/nix/store/0i8d5j0w45jkrm5s8r7727gz1ygl0mnj-papis-0.5.3
/nix/store/va2xvbngvbbjykkq73z851f3n2mx1msr-radicale-2.1.9

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: khal, papis, radicale

Partial log (click to expand)

  File "/nix/store/j75wjn09qs81q015x4imjlylb12lqh23-python3.6-pytest-3.6.2/lib/python3.6/site-packages/_pytest/fixtures.py", line 900, in __call__
    "fixture is being applied more than once to the same function"
ValueError: fixture is being applied more than once to the same function
ERROR: could not load /build/source/tests/conftest.py

builder for '/nix/store/7avgrllswk39z92rn0dmmi3cpdkjrhqb-python3.6-pytest-httpbin-0.3.0.drv' failed with exit code 4
cannot build derivation '/nix/store/j6c1bsjix05ngvc2bz879wi7mcszspka-python3.6-vcrpy-1.12.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/h6cc7ncxsnwjffih8g8pxwzg76rs12l5-python3.6-habanero-0.6.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/df7g9acjvmmnw1pacw17akvgjqmxnl57-papis-0.5.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/df7g9acjvmmnw1pacw17akvgjqmxnl57-papis-0.5.3.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: khal, papis, radicale

Partial log (click to expand)

  --vim       Vim based UI
sync
usage: papis sync [-h]

optional arguments:
  -h, --help  show this help message and exit
zotero/test_zotero.sh
/nix/store/ci1f07bdw37y0bq41ykpqyqxy3hya8rz-khal-0.9.9
/nix/store/23yj85zvbwnd7sbimbc5k6hsk1ndf71g-papis-0.5.3
/nix/store/ra9qf2k4yz6d0s0v7g1i0mayq7x6iysm-radicale-2.1.9

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: khal, papis, radicale

Partial log (click to expand)

  --vim       Vim based UI
sync
usage: papis sync [-h]

optional arguments:
  -h, --help  show this help message and exit
zotero/test_zotero.sh
/nix/store/ci1f07bdw37y0bq41ykpqyqxy3hya8rz-khal-0.9.9
/nix/store/psl93c5s7clrha4c0jsf4y3v3xfja89b-papis-0.5.3
/nix/store/ra9qf2k4yz6d0s0v7g1i0mayq7x6iysm-radicale-2.1.9

@xeji
Copy link
Contributor

xeji commented Jun 29, 2018

@GrahamcOfBorg test radicale

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.radicale

Partial log (click to expand)

radicale# [   24.777470] radicale[1579]: [7feb9d491700] DEBUG: Sanitized path: '/.web/'
radicale# [   24.778271] radicale[1579]: [7feb9d491700] INFO: Successful login: 'someuser'
radicale# [   24.779139] radicale[1579]: [7feb9d491700] INFO: GET response status for '/.web/' in 0.008 seconds: 200 OK
radicale: exit status 0
test script finished in 28.93s
cleaning up
killing radicale (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/zc5rxy0988ly41wm3hmsmk5w19xbp6kp-vm-test-run-radicale

@xeji xeji merged commit ad112ca into NixOS:master Jun 29, 2018
@dotlambda dotlambda deleted the dateutil-2.7-fixes branch June 29, 2018 22:47
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.radicale

Partial log (click to expand)

radicale# [   66.943137] radicale[1583]:  'SCRIPT_NAME': '',
radicale# [   66.948568] radicale[1583]:  'SERVER_NAME': 'localhost',
radicale: exit status 0
radicale# [   66.953877] radicale[1583]:  'SERVER_PORT': '5232',
test script finished in 68.07s
cleaning up
killing radicale (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/dwd9zxai2wwrh5raalw7sl0n6rp00jmx-vm-test-run-radicale

@dotlambda dotlambda mentioned this pull request Jun 30, 2018
Closed
mnacamura pushed a commit to mnacamura/nixpkgs that referenced this pull request Jul 3, 2018
@gebner
khard: fix build
ebf4cfb 
Copied the fix from NixOS#42782
@dotlambda dotlambda mentioned this pull request Jul 8, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @GrahamcOfBorg @xeji