nethack: nethack-x11 package created #42766
Conversation
pkgs/top-level/all-packages.nix
Outdated
| @@ -19568,6 +19568,10 @@ with pkgs; | |||
|
|
|||
| nethack = callPackage ../games/nethack { }; | |||
|
|
|||
| nethack-x11 = nethack.override { | |||
There was a problem hiding this comment.
Is it okay to leave this out? I much prefer to have users set up these kind of overrides in their configs. You can definitely add documentation to the Nixpkgs manual if you think it needs to be more disoverable.
There was a problem hiding this comment.
I don't know how correct my approach is, but I used the crawlTiles and crawl packages as a sample. Everything is done exactly the same way there.
What would you suggest to do in this case? Basically, I could make a separate nix expression for the x11 version and maintain it separately.
There was a problem hiding this comment.
No - I definitely think it's good to reuse the nethack expression - I just don't want it to go in all-packages.nix.
There was a problem hiding this comment.
nethack-x11 = callPackage ../games/nethack { x11Mode = true; };
Perhaps it would be better?
If x11Mode is false, ncurses NetHack version will be built (nethack). If x11Mode is true, x11 NetHack version will be built (nethack-x11). NetHack DevTeam provide x11 version support only for Linux.
|
Thanks! |
ghost
mentioned this pull request
If x11Mode is false, ncurses NetHack version will be built (nethack).
If x11Mode is true, x11 NetHack version will be built (nethack-x11).
NetHack DevTeam provide x11 version support only for Linux.
Motivation for this change
To play a graphical version of NetHack on NixOS.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)/cc @abbradar