New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
atom, atom-beta: fixed #42730 #42769
Conversation
Swithed atom to use gtk3 instead of 2. Fixed channel detection in the atom startup script.
@szeck87 Could you check if this fixes your problem? |
I'm out of town without my laptop until later tonight, I'll check it then. |
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: atom, atom-beta Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: atom, atom-beta Partial log (click to expand)
|
@Synthetica9 how do I add a channel to Nix pointing to this change to test out? |
Assuming you have already cloned the nixpkgs repo: git remote add synthetica https://github.com/Synthetica9/nixpkgs
git fetch synthetica
git checkout synthetica/atom-fix-42730
nix-build . -A atom -A atom-beta hmu if you need any more help |
OK, I'm not sure if the problem is fixed, or if I didn't build it properly, or if there is some other cause of this error. https://travis-ci.org/szeck87/atom-beautify/jobs/398692985 |
This seems to be a different error, with the problem being that nix-build only builds the derivation, but doesn't make it available in PATH. If you want that, you'd do:
|
OK, that got me past that error. But either it didn't build atom and atom-beta from the repository or this fix didn't work: https://travis-ci.org/szeck87/atom-beautify/jobs/399155559 and https://travis-ci.org/szeck87/atom-beautify/jobs/399155556 |
@Synthetica9 I have a Docker container running Travis to help debug. Let me know what to look for. |
@Synthetica9 I ran Travis using an ugly hack (curl'ing your changed files right into default.nix and env.nix under the .nix-defexpr directory) and it seems to work. |
Is this ready to merge? |
@xeji Yeah, I believe so. |
@szeck87 the The last evaluation with all tests passed was https://hydra.nixos.org/build/76782747 , three days ago. |
@xeji I understand, but the commit it's using now is from 25 days ago. Is it looking from the 6/24 release? https://nixos.org/channels/nixpkgs-unstable |
I see. Looks like the mirror lags behind the git channel. Don't know why. Opened #43077 . |
Swithed atom to use gtk3 instead of 2.
Fixed channel detection in the atom startup script.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)