Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth2_proxy: add nginx vhost module #42775

Merged
merged 2 commits into from Jul 5, 2018
Merged

oauth2_proxy: add nginx vhost module #42775

merged 2 commits into from Jul 5, 2018

Conversation

mkaito
Copy link
Contributor

@mkaito mkaito commented Jun 29, 2018

Motivation for this change

This should have been in #39002

This module makes it very easy to configure nginx to use oauth2_proxy

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

lukateras
lukateras reviewed Jul 5, 2018
View reviewed changes
nixos/modules/services/security/oauth2_proxy_nginx.nix
in
{
options.services.oauth2_proxy.nginx = {
proxy = mkOption {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there cases where this can be something other than config.services.oauth2_proxy.httpAddress?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yorickvP

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, when the proxy runs on another system.

@lukateras lukateras merged commit 1bb95d8 into NixOS:master Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorickvP yorickvP yorickvP left review comments

@lukateras lukateras lukateras approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkaito @yorickvP @lukateras @GrahamcOfBorg