♻️ Rename buildAttributes flag to better show actual effect #2438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag only causes parameters with empty strings to be skipped, not all empty() values.
|
Why closing btw? |
|
It is one and a half years old and didn't seem to lead anywhere. |
|
Sorry about that. If you try pinging anyone by leaving a comment, or requesting a review, someone should notice this... Just remembered that I have some PRs left here as well. |
|
I cherry picked the commit and fixed the conflict. Sorry, I simply forgot about this tiny PR. @micgro42 you're welcome to merge simple stuff like this yourself in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag only causes parameters with empty strings to be skipped, but not with any other empty() values.