thinkpad x1 gen6 #62
thinkpad x1 gen6 #62
Conversation
| @@ -1,10 +0,0 @@ | |||
| { lib, pkgs, ... }: | |||
There was a problem hiding this comment.
This breaks every other configuration in this directory, since they all import this.
|
|
||
| boot.kernelModules = [ "acpi" "thinkpad-acpi" "acpi-call" ]; | ||
| boot.extraModulePackages = [ config.boot.kernelPackages.acpi_call ]; | ||
| boot.extraModprobeConfig = "options thinkpad_acpi experimental=1 fan_control=1"; |
There was a problem hiding this comment.
Maybe improve the acpi_call module in the parent directory and import that?
| boot.extraModulePackages = [ config.boot.kernelPackages.acpi_call ]; | ||
| boot.extraModprobeConfig = "options thinkpad_acpi experimental=1 fan_control=1"; | ||
|
|
||
| environment.systemPackages = with pkgs; [ |
There was a problem hiding this comment.
If you import the default module this is implied by that (in common/pc/laptop)
| hardware.pulseaudio.enable = true; | ||
|
|
||
| # handle lid close hibernate, suspend, or ignore | ||
| systemd.extraConfig = ""; |
There was a problem hiding this comment.
Did you mean to include this?
|
|
||
| # Thinkpad power services with some sample values | ||
| services.tlp.enable = true; | ||
| services.tlp.extraConfig = '' |
There was a problem hiding this comment.
I wonder if it makes sense to put these in the default thinkpad module, since presumably they apply generally?
There was a problem hiding this comment.
I think there are some differences between generations. AFAIK The oldest thinkpads on the list should behave differently with CPU_SCALING_GOVERNOR_ON_BAT=powersave since powersave behaves differently depending on the scaling driver. Using powersave with pstate in newer generations isn't like powersave in the previous generations.
BTW. I don't think disabling bluetooth on startup should be a default. IMHO making some tweaks here by default is okay but making tradeoffs like this is better left to be opt in.
|
|
||
| # enable sound | ||
| sound.enable = true; | ||
| hardware.pulseaudio.enable = true; |
There was a problem hiding this comment.
These probably shouldn't be here, since people may want to make their own choices about sound settings. Generally any direct settings should probably have mkDefault so that other people's settings will override them.
|
I think they're both maybe a little opinionated? It would be good if we had clearer guidelines about which options you should set vs. leave to users to set. I also think it would be nice if we could share as much as possible between the thinkpad configurations otherwise there's a ton of copy pasting. |
|
@michaelpj i found things not to be to opinionated in #60. i think @yegortimoshenko has an idea about guidelines, but it would be nicer to see them written down. sharing between thinkpad, with current setup this is definitely possible. i personally see this as an optimization step. once we notice that things duplicate we move the to "lower" placing default.nix. |
|
closing this since this PR was reviewed in #60 (which just got merged) and integrated non-opinionated configuration from this PR. |
First stab at Thinkpad x1 gen6 profile.