Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.salmon-mail: fix tests #42753

Merged
merged 1 commit into from Jun 29, 2018
Merged

pythonPackages.salmon-mail: fix tests #42753

merged 1 commit into from Jun 29, 2018

Conversation

jluttine
Copy link
Member

@jluttine jluttine commented Jun 29, 2018 •
edited

Motivation for this change

After the upgrade to 3.0.1, unit tests broke. Here's a fix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@jluttine jluttine requested a review from FRidh as a code owner June 29, 2018 05:52
@jluttine jluttine changed the title pythonPackages.salmon-mail: 3.0.0 -> 3.0.1 pythonPackages.salmon-mail: fix tests Jun 29, 2018
@FRidh
Copy link
Member

FRidh commented Jun 29, 2018

@GrahamcOfBorg build pythonPackages.salmon-mail python3Packages.salmon-mail

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.salmon-mail, python3Packages.salmon-mail

Partial log (click to expand)

salmon/utils.py                  72      7    90%
salmon/view.py                   21      0   100%
-------------------------------------------------
TOTAL                          1469     81    94%
----------------------------------------------------------------------
Ran 122 tests in 2.770s

OK
/nix/store/3yrbvjn6hzvv3q49sp1cb2kq7ba2h8b2-python2.7-salmon-mail-3.0.1
/nix/store/41gn4grsf4qm5r9lqs9lpjbrph3skwg2-python3.6-salmon-mail-3.0.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pythonPackages.salmon-mail, python3Packages.salmon-mail

Partial log (click to expand)

salmon/utils.py                  72      7    90%
salmon/view.py                   21      0   100%
-------------------------------------------------
TOTAL                          1469     81    94%
----------------------------------------------------------------------
Ran 122 tests in 2.171s

OK
/nix/store/zl6kahb02p17aj2hgr65rm3r1dydhqzb-python2.7-salmon-mail-3.0.1
/nix/store/brq2qiib4z89ivbi12s7rp82mqrp1bp6-python3.6-salmon-mail-3.0.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.salmon-mail, python3Packages.salmon-mail

Partial log (click to expand)

salmon/utils.py                  72      7    90%
salmon/view.py                   21      0   100%
-------------------------------------------------
TOTAL                          1469     81    94%
----------------------------------------------------------------------
Ran 122 tests in 6.328s

OK
/nix/store/4r80pbci14fza3w59ap8wqk3myn7fmi4-python2.7-salmon-mail-3.0.1
/nix/store/ihnwc11vvmip9vvclrmwq0y2kjpb7z45-python3.6-salmon-mail-3.0.1

@dotlambda dotlambda merged commit a476595 into NixOS:master Jun 29, 2018
@jluttine jluttine deleted the update-salmon-3.0.1 branch June 29, 2018 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jluttine @FRidh @GrahamcOfBorg @dotlambda