Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 14f00d78df3e
Choose a base ref
...
head repository: jruby/jruby
compare: 86736e38c309
Choose a head ref
  • 4 commits
  • 4 files changed
  • 1 contributor

Commits on Jun 29, 2018

  1. handle setEncoding better for shared strings 

    only set when changed - no need to modify() (copy) otherwise
+ do not setEncoding for new strings when can use constructor
    @kares
    kares committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    81dfd2d View commit details
    Browse the repository at this point in the history

  2. [fix] byte-list cached version of readline 

    which never worked as intended, the slow-path is taken when
specifying opts e.g. `file.each_line(limit)`

performance is ~ same -- but there's less byte[] allocation

+ reviewed - cleaned up warnings in OpenFile
    @kares
    kares committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    deead6d View commit details
    Browse the repository at this point in the history

  3. [refactor] drop byte-list cache on IO.readline and friends 

    still needs tricks to handle string sharing - can not get this
reasonably right with current setup.
    @kares
    kares committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    4c991f7 View commit details
    Browse the repository at this point in the history

  4. [refactor] do not check Hash options twice

    @kares
    kares committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    86736e3 View commit details
    Browse the repository at this point in the history