add .new and .empty? to HTTP::Params #6241
Conversation
src/http/params.cr
Outdated
| @@ -291,6 +296,11 @@ module HTTP | |||
| raw_params.delete(name) | |||
| end | |||
|
|
|||
| # Whether the collection contains any params. | |||
| def empty? | |||
| raw_params.empty? | |||
There was a problem hiding this comment.
You can use delegate empty?, to: @raw_params
Sorry for edits, I confuse myself :|
There was a problem hiding this comment.
There was a problem hiding this comment.
In fact #delegate is the right thing, and doesn't change the value.
In the API example, the delegate empty?, capitalize, to: @string changes the string to a capitalized one because a method was specified.
So here, delegate emtpy?, to: @raw_params
There was a problem hiding this comment.
I knew that and i use it much in my project. use this because other methods not use delegate. so...i made a mistake 🤣
|
|
icyleaf
force-pushed
the
feature-http-params
branch
from
5352c28
to
6a3597c
Compare
|
I rebase the commit, i think it is better use delegate with |
|
CI says
|
|
@bcardiff i found format check error in comments, is that must be formatted? |
|
Yes, the formatter also formats code in comments. |
src/http/params.cr
Outdated
| @@ -76,6 +76,11 @@ module HTTP | |||
| end | |||
| end | |||
|
|
|||
| # Returns the empty `HTTP::Params`. | |||
| def self.new | |||
| Params.new({} of String => Array(String)) | |||
There was a problem hiding this comment.
Why not simply add a default to def initialize, then document that?
Doc should be
Returns an empty
HTTP::Params.
icyleaf
force-pushed
the
feature-http-params
branch
from
6e22cd7
to
c104840
Compare
icyleaf
force-pushed
the
feature-http-params
branch
from
c104840
to
47b0986
Compare
|
@RX14 Code update, please review again, thanks. |
Add two new methods to
HTTP::Params:self.new
empty?
Here is no simple way to check if not empty.