Fix #150 - Check ELF endianness before writing new runpath #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the way fields are written in the dynamic section in order to account the architecture of the target ELF file. Instead of copying the raw data, use the helper functions to convert endianness. Signed-off-by: Bryce Ferguson <bryce.ferguson@rockwellcollins.com>
|
@UraniumKnight there are conflicts now, is this PR still needed on master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a change to the way the RUNPATH field is updated in the dynamic section. Currently, patchelf does not take into account the target architecture of the ELF file before doing this (when --make-rpath-relative is specified). Thus, the elf file ends up having an invalid tag for RUNPATH if the endianness differs. (0x1d000000 instead of 0x0000001d).
The change proposed here updates the way these fields are written using the already defined endian-safe functions. Tested on both PowerPC and ARM targets with a x86_64 host.