Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openmvs: build with CGAL 4.12 #42590

Merged
merged 1 commit into from Jun 29, 2018
Merged

openmvs: build with CGAL 4.12 #42590

merged 1 commit into from Jun 29, 2018

Conversation

TimPut
Copy link
Contributor

@TimPut TimPut commented Jun 25, 2018 •
edited

Motivation for this change

Changes to the folder structure of new versions of CGAL broke building of this package.

Things done

added explicit CMAKE declaration of CGAL library location.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

NOTE: This fixes the building of the package, but in order to run the binaries I needed to manually append the location of the openMVS .so files in the nix/store/ to my LD_LIBRARY_PATH environment variable. This is clearly not a complete solution. I'd appreciate it if anyone can direct me towards the correct way to fix the binaries.

@TimPut
Copy link
Contributor Author

TimPut commented Jun 26, 2018

@GrahamcOfBorg build openmvs

@TimPut
openmvs: fix CGAL 4.12 dependency
385114d 
patch executables with openMVS library path
@matthewbauer
Copy link
Member

@GrahamcOfBorg build openmvs

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: openmvs

Partial log (click to expand)

CMake Error at CMakeLists.txt:225 (message):
  -- Ceres requires Eigen version >= 3.3.4 on aarch64.  Detected version of
  Eigen is: 3.2.10.


-- Configuring incomplete, errors occurred!
See also "/build/ceres-solver-1.14.0/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/iwdvmnaypnap3pl3rq07fx434mz8wl9f-ceres-solver-1.14.0.drv' failed with exit code 1
cannot build derivation '/nix/store/fjgvsdmjxqhs6karf4rydx9jy9i5q4hx-openmvs-unstable-2018-05-26.drv': 1 dependencies couldn't be built
error: build of '/nix/store/fjgvsdmjxqhs6karf4rydx9jy9i5q4hx-openmvs-unstable-2018-05-26.drv' failed

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: openmvs

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openmvs

Partial log (click to expand)

shrinking /nix/store/4blm4g29rsba79pszix4grkaxcp1p93h-openmvs-unstable-2018-05-26/lib/OpenMVS/libMVS.so
shrinking /nix/store/4blm4g29rsba79pszix4grkaxcp1p93h-openmvs-unstable-2018-05-26/bin/InterfaceVisualSFM
shrinking /nix/store/4blm4g29rsba79pszix4grkaxcp1p93h-openmvs-unstable-2018-05-26/bin/DensifyPointCloud
shrinking /nix/store/4blm4g29rsba79pszix4grkaxcp1p93h-openmvs-unstable-2018-05-26/bin/ReconstructMesh
shrinking /nix/store/4blm4g29rsba79pszix4grkaxcp1p93h-openmvs-unstable-2018-05-26/bin/RefineMesh
shrinking /nix/store/4blm4g29rsba79pszix4grkaxcp1p93h-openmvs-unstable-2018-05-26/bin/TextureMesh
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4blm4g29rsba79pszix4grkaxcp1p93h-openmvs-unstable-2018-05-26/lib  /nix/store/4blm4g29rsba79pszix4grkaxcp1p93h-openmvs-unstable-2018-05-26/bin
patching script interpreter paths in /nix/store/4blm4g29rsba79pszix4grkaxcp1p93h-openmvs-unstable-2018-05-26
checking for references to /build in /nix/store/4blm4g29rsba79pszix4grkaxcp1p93h-openmvs-unstable-2018-05-26...

@matthewbauer matthewbauer merged commit 2171fc4 into NixOS:master Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TimPut @matthewbauer @GrahamcOfBorg