Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Exception#inspect_with_backtrace where sensible #6261

Merged
merged 1 commit into from Jun 25, 2018
Merged

Use Exception#inspect_with_backtrace where sensible #6261

merged 1 commit into from Jun 25, 2018

Conversation

RX14
Copy link
Contributor

@RX14 RX14 commented Jun 25, 2018 •
edited

"you've found a bug" error messages are currently formatted a bit weird, this fixes it. Also gives us showing the type of the exception for free.

Same with Spec.

@sdogruyol sdogruyol merged commit fc01468 into crystal-lang:master Jun 25, 2018
@RX14 RX14 added this to the 0.25.1 milestone Jun 25, 2018
This was referenced Jul 1, 2018
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

@sdogruyol sdogruyol sdogruyol approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:compiler topic:stdlib
Projects
None yet
Milestone
0.25.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RX14 @jhass @sdogruyol