dunst: Also install dunstify #42579
Merged
dunst: Also install dunstify #42579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
reviewed
Jun 26, 2018
| postInstall = '' | ||
| install -Dm755 dunstify $out/bin |
There was a problem hiding this comment.
This binary should also be wrapped with GDK_PIXBUF_MODULE_FILE, no?
There was a problem hiding this comment.
No, dunstify is just a CLI client for the private functionality of dunst which is exposed by D-Bus.
There was a problem hiding this comment.
I tested and I can call dunstify with --icon, which would be the only place I'd expect pixbuf to be used.
|
Please consider to put this behind an option flag as it is not guaranteed to build with every version of libnotify which is why upstream does not build and install it by default. |
|
@jfrankenau Fixed and rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Dunst was lacking dunstify which is really useful to use non-standard features of the notification daemon.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)