Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make-bootstrap-tools-cross: remove broken i686-musl variant #42576

Merged

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 25, 2018

Not terribly difficult to get this working, but until it does
remove it so the cross jobset doesn't have the failures this introduces.

Easy enough to restore in the future when this is fixed :).

cc #42407

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Not terribly difficult to get this working, but until it does
remove it so the cross jobset doesn't have the failures this introduces.
@dtzWill
Copy link
Member Author

dtzWill commented Jun 25, 2018

To clean up since known-failing and I'm not sure when I'll be able to fix it. If it's not bothering anyone we can leave it but I am submitting this to make it easy to remove should that be preferred! :)

@matthewbauer
Copy link
Member

Yeah i think this is good to do.

@matthewbauer matthewbauer merged commit 8bc9419 into NixOS:master Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants