Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cheroot: fixed tests #42716

Merged
merged 2 commits into from Jun 29, 2018
Merged

pythonPackages.cheroot: fixed tests #42716

merged 2 commits into from Jun 29, 2018

Conversation

xvapx
Copy link
Contributor

@xvapx xvapx commented Jun 28, 2018

Motivation for this change

Fix #42715

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xvapx xvapx requested a review from FRidh as a code owner June 28, 2018 07:54
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.cheroot python3.pkgs.cheroot

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.cheroot, python3.pkgs.cheroot

Partial log (click to expand)

    return self.obtain(req, installer)
  File "/nix/store/ad7n4dkms5msmay061q5sj2n2dwdjfrs-python3.6-bootstrapped-pip-10.0.1/lib/python3.6/site-packages/pkg_resources/__init__.py", line 1065, in obtain
    return installer(requirement)
  File "/nix/store/ad7n4dkms5msmay061q5sj2n2dwdjfrs-python3.6-bootstrapped-pip-10.0.1/lib/python3.6/site-packages/setuptools/dist.py", line 581, in fetch_build_egg
    return cmd.easy_install(req)
  File "/nix/store/ad7n4dkms5msmay061q5sj2n2dwdjfrs-python3.6-bootstrapped-pip-10.0.1/lib/python3.6/site-packages/setuptools/command/easy_install.py", line 667, in easy_install
    raise DistutilsError(msg)
distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('setuptools_scm_git_archive>=1.0')
builder for '/nix/store/7yv498ivw3n7c676fhivqagpzdm7icnm-python3.6-cheroot-6.3.2.drv' failed with exit code 1
error: build of '/nix/store/29dd1jj24nvwbyxijb933q3k4mdqx9si-python2.7-cheroot-6.3.2.drv', '/nix/store/7yv498ivw3n7c676fhivqagpzdm7icnm-python3.6-cheroot-6.3.2.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python2.pkgs.cheroot, python3.pkgs.cheroot

Partial log (click to expand)

    return self.obtain(req, installer)
  File "/nix/store/cgsn3d8rq42ijdk3z6lygkrx02msfhiv-python3.6-bootstrapped-pip-10.0.1/lib/python3.6/site-packages/pkg_resources/__init__.py", line 1065, in obtain
    return installer(requirement)
  File "/nix/store/cgsn3d8rq42ijdk3z6lygkrx02msfhiv-python3.6-bootstrapped-pip-10.0.1/lib/python3.6/site-packages/setuptools/dist.py", line 581, in fetch_build_egg
    return cmd.easy_install(req)
  File "/nix/store/cgsn3d8rq42ijdk3z6lygkrx02msfhiv-python3.6-bootstrapped-pip-10.0.1/lib/python3.6/site-packages/setuptools/command/easy_install.py", line 667, in easy_install
    raise DistutilsError(msg)
distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('setuptools_scm_git_archive>=1.0')
builder for '/nix/store/zm6lqqd8ifvz018f9n7ihl3lzm15m7hp-python3.6-cheroot-6.3.2.drv' failed with exit code 1
error: build of '/nix/store/aly7gx2nr0pb1wk7c69vgvp4s4hax338-python2.7-cheroot-6.3.2.drv', '/nix/store/zm6lqqd8ifvz018f9n7ihl3lzm15m7hp-python3.6-cheroot-6.3.2.drv' failed

@dotlambda
Copy link
Member

It seems like setuptools_scm_git_archive should be added to nativeBuildInputs.

@xvapx
Copy link
Contributor Author

xvapx commented Jun 28, 2018

Yep, I'm having the same problem, but it was there before this patch.
I was trying to build and test cheroot before trying to add setuptools_scm_git_archive, which is not packaged in nixpkgs.

@FRidh
Copy link
Member

FRidh commented Jun 28, 2018

We can also just patch away setuptools_scm* entirely and insert the version ourselves:

substituteInPlace setup.py ---replace "use_scm_version=True" "version=${version}" \
  --replace "'setuptools_scm>=1.15.0'," "" \
  --replace "'setuptools_scm_git_archive>=1.0'," ""

@xvapx
Copy link
Contributor Author

xvapx commented Jun 28, 2018 •
edited

@FRidh It works, but cherrypy is missing backports_functools_lru_cache as a checkInput.
Adding backports_functools_lru_cache to cherrypy works, but it's still failing two tests, I'm looking at it.
Should the changes to cherrypy be in a different PR?

EDIT: Ok, cherrypy failed tests are due to missing requests_toolbelt too. Adding this seems to fix cherrypy.

@FRidh
Copy link
Member

FRidh commented Jun 28, 2018

Same PR, but different commits.

@xvapx xvapx force-pushed the PR/fix-pythonPackages.cheroot branch from 0e42d69 to f11281b Compare June 28, 2018 09:15
@xvapx
Copy link
Contributor Author

xvapx commented Jun 28, 2018

Thanks, done.

@FRidh FRidh merged commit d854e3c into NixOS:master Jun 29, 2018
@xvapx xvapx deleted the PR/fix-pythonPackages.cheroot branch July 14, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xvapx @dotlambda @GrahamcOfBorg @FRidh