Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: 3.7.0rc1 -> 3.7.0 #42707

Closed
wants to merge 1 commit into from
Closed

python: 3.7.0rc1 -> 3.7.0 #42707

wants to merge 1 commit into from

Conversation

dirn
Copy link
Contributor

@dirn dirn commented Jun 28, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dirn dirn requested a review from FRidh as a code owner June 28, 2018 05:12
@FRidh
Copy link
Member

FRidh commented Jun 28, 2018

Thanks. I just pushed 7261a66.

@FRidh FRidh closed this Jun 28, 2018
@dirn
Copy link
Contributor Author

dirn commented Jun 29, 2018 •
edited

I see that you've provided a different value for sha256. I used

$ openssl sha256 Python-3.7.0.tar.xz

Should I have done it some other way?

@FRidh
Copy link
Member

FRidh commented Jun 29, 2018

It's just a different base, I suppose yours is fine as well.

@dirn
Copy link
Contributor Author

dirn commented Jun 29, 2018

I wasn’t sure because I was working on a version bumpfor another expression and ended up with a longer hash than what was already there. Thanks.

@dirn dirn deleted the python-3.7.0 branch June 30, 2018 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dirn @FRidh @GrahamcOfBorg @Janik-Haag