Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch5: Set classpath for elasticsearch-plugin #42723

Merged
merged 1 commit into from Jul 6, 2018

Conversation

thefloweringash
Copy link
Member

@thefloweringash thefloweringash commented Jun 28, 2018

Motivation for this change

In elasticsearch5, elasticsearch-plugin fails with the error message:

Error: Could not find or load main class org.elasticsearch.plugins.PluginCli

Since it forces the class path to ES_HOME/lib/*, and makes it difficult to override. This change makes the class path be specified by ES_CLASSPATH, like the main elasticsearch script, so the wrapper can set it to the correct path.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants