Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hostapd: use WPA2 instead of WPA1 by default #42709

Merged
merged 1 commit into from Jun 30, 2018
Merged

hostapd: use WPA2 instead of WPA1 by default #42709

merged 1 commit into from Jun 30, 2018

Conversation

jollheef
Copy link
Member

Motivation for this change

WPA2 must be default behaviour, because it's more secure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

This is a good change, thanks!

Could you also add a release note (https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-1809.xml) as this would potentially be breaking existing setups relying on WPA.

@Mic92
Copy link
Member

Mic92 commented Jun 28, 2018

Also the risk is low, since wpa2 should be supported by the majority of devices these days.

@jollheef
Copy link
Member Author

@adisbladis, fixed.

globin
globin approved these changes Jun 30, 2018
View reviewed changes
Copy link
Member

@globin globin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the typo looks good to me

nixos/doc/manual/release-notes/rl-1809.xml Outdated
@@ -330,6 +330,11 @@ inherit (pkgs.nixos {
will be added to <literal>environment.systemPackages</literal>.
</para>
</listitem>
<listitem>
<para>
The module <option>services.networking.hostapd</option> now use WPA2 by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use -> uses

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@adisbladis adisbladis merged commit dd608f8 into NixOS:master Jun 30, 2018
@adisbladis
Copy link
Member

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin globin approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jollheef @adisbladis @Mic92 @globin @GrahamcOfBorg @Janik-Haag