init: holochain-go at 0.1.0-alpha #42725

gavinrogers · 2018-06-28T12:10:42Z

Holochain is a platform for creating an unenclosable carrier upon which
highly-scalable dApps and smart contracts can be built. This is the holochain
team's initial implimentation in go. A rust version is under development.

Motivation for this change

Add the holochain core to nixpkgs to allow app developers to bootstrap more quickly: allow people to run their own holochain node.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

Holochain is a platform for creating an unenclosable carrier upon which highly-scalable dApps and smart contracts can be built. This is the holochain team's initial implimentation in go. A rust version is under development.

Mic92 · 2018-06-28T20:46:40Z

pkgs/servers/holochain-go/default.nix

+  src = fetchgit {
+    inherit rev;
+    url = "https://github.com/holochain/holochain-proto";
+    sha256 = "19l29jnr63ximmyn4i4llv2mdwh306c2mpzmx2anj9z12wjpach0";


Can you use fetchFromGitHub since you are not using git submodules?

Mic92 · 2018-06-28T20:47:08Z

pkgs/servers/holochain-go/default.nix

+
+  goDeps = ./deps.nix;
+
+  # TODO: add metadata https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes


this one can be removed.

Mic92 · 2018-06-28T20:47:44Z

pkgs/servers/holochain-go/default.nix

@@ -0,0 +1,31 @@
+# This file was generated by https://github.com/kamilchm/go2nix v1.2.1


Since this was manually edited, we should not claim it was generated.

Ah ok that makes sense!

Mic92 · 2018-06-28T20:52:12Z

pkgs/servers/holochain-go/default.nix

+
+buildGoPackage rec {
+  name = "holochain-go${version}";
+  version = "v0.1.0-alpha";


we usually do not include the v in the name, but rather do: holochain-go-0.1.0-alpha:

nix-repl> builtins.parseDrvName "holochain-gov0.1.0-alpha" { name = "holochain-gov0.1.0-alpha"; version = ""; } nix-repl> builtins.parseDrvName "holochain-go-0.1.0-alpha" { name = "holochain-go"; version = "0.1.0-alpha"; }

@LnL7

/cc @LnL7 @3noch

This is a good way to test that plist works. Sorry for the large diff. There are a bunch of cleanups in here that needed to be done. Should make it possible to use in cross compilation.

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/iperf/versions. These checks were done: - built on NixOS - /nix/store/c7p3b3b353pssma0cg1wg78pfs6x2is3-iperf-2.0.12/bin/iperf passed the binary check. - 1 of 1 passed binary check by having a zero exit code. - 0 of 1 passed binary check by having the new version present in output. - found 2.0.12 with grep in /nix/store/c7p3b3b353pssma0cg1wg78pfs6x2is3-iperf-2.0.12 - directory tree listing: https://gist.github.com/457110ea6db3cd3dbd6c9bc7ff82477a - du listing: https://gist.github.com/86655ffd63846a5d3a473393af8e4da9

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/eid-mw/versions. These checks were done: - built on NixOS - Warning: no invocation of /nix/store/sis599r39a2g7kvnv1d09l6sy6kn45l0-eid-mw-4.4.3/bin/eid-viewer had a zero exit code or showed the expected version - Warning: no invocation of /nix/store/sis599r39a2g7kvnv1d09l6sy6kn45l0-eid-mw-4.4.3/bin/.eid-viewer-wrapped had a zero exit code or showed the expected version - /nix/store/sis599r39a2g7kvnv1d09l6sy6kn45l0-eid-mw-4.4.3/bin/beid-update-nssdb passed the binary check. - /nix/store/sis599r39a2g7kvnv1d09l6sy6kn45l0-eid-mw-4.4.3/bin/eid-nssdb passed the binary check. - 2 of 4 passed binary check by having a zero exit code. - 0 of 4 passed binary check by having the new version present in output. - found 4.4.3 with grep in /nix/store/sis599r39a2g7kvnv1d09l6sy6kn45l0-eid-mw-4.4.3 - directory tree listing: https://gist.github.com/3bca8b9d321e62009daf1d388923ec47 - du listing: https://gist.github.com/64220a7b5b960cbd2ec3bb5f61c93a29

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/deadbeef-mpris2-plugin/versions. These checks were done: - built on NixOS - 0 of 0 passed binary check by having a zero exit code. - 0 of 0 passed binary check by having the new version present in output. - found 1.11 with grep in /nix/store/isa0i2bjry1xg3l8895k10w1zwd4ij9f-deadbeef-mpris2-plugin-1.11 - directory tree listing: https://gist.github.com/020d669dc365b545d61d171c5566d03a - du listing: https://gist.github.com/9cd938a3d8215dbc4f00d62fe20ca4f5

it should be targetPackages.darwin.iosSdkPkgs.libraries

There is some weird issue with 9.4 that needs to be resolved. 8.2 is used by iOS anyway so that makes it easier.

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gdcm/versions. These checks were done: - built on NixOS - /nix/store/b5k2wcykj6s3j1rax851vpzyj6amqpvk-gdcm-2.8.7/bin/gdcm2vtk passed the binary check. - /nix/store/b5k2wcykj6s3j1rax851vpzyj6amqpvk-gdcm-2.8.7/bin/gdcmviewer passed the binary check. - Warning: no invocation of /nix/store/b5k2wcykj6s3j1rax851vpzyj6amqpvk-gdcm-2.8.7/bin/gdcm2pnm had a zero exit code or showed the expected version - /nix/store/b5k2wcykj6s3j1rax851vpzyj6amqpvk-gdcm-2.8.7/bin/gdcmdump passed the binary check. - Warning: no invocation of /nix/store/b5k2wcykj6s3j1rax851vpzyj6amqpvk-gdcm-2.8.7/bin/gdcmdiff had a zero exit code or showed the expected version - /nix/store/b5k2wcykj6s3j1rax851vpzyj6amqpvk-gdcm-2.8.7/bin/gdcmraw passed the binary check. - /nix/store/b5k2wcykj6s3j1rax851vpzyj6amqpvk-gdcm-2.8.7/bin/gdcmscanner passed the binary check. - /nix/store/b5k2wcykj6s3j1rax851vpzyj6amqpvk-gdcm-2.8.7/bin/gdcmanon passed the binary check. - /nix/store/b5k2wcykj6s3j1rax851vpzyj6amqpvk-gdcm-2.8.7/bin/gdcmgendir passed the binary check. - /nix/store/b5k2wcykj6s3j1rax851vpzyj6amqpvk-gdcm-2.8.7/bin/gdcmimg passed the binary check. - /nix/store/b5k2wcykj6s3j1rax851vpzyj6amqpvk-gdcm-2.8.7/bin/gdcmconv passed the binary check. - /nix/store/b5k2wcykj6s3j1rax851vpzyj6amqpvk-gdcm-2.8.7/bin/gdcmtar passed the binary check. - /nix/store/b5k2wcykj6s3j1rax851vpzyj6amqpvk-gdcm-2.8.7/bin/gdcminfo passed the binary check. - /nix/store/b5k2wcykj6s3j1rax851vpzyj6amqpvk-gdcm-2.8.7/bin/gdcmscu passed the binary check. - Warning: no invocation of /nix/store/b5k2wcykj6s3j1rax851vpzyj6amqpvk-gdcm-2.8.7/bin/gdcmxml had a zero exit code or showed the expected version - /nix/store/b5k2wcykj6s3j1rax851vpzyj6amqpvk-gdcm-2.8.7/bin/gdcmpap3 passed the binary check. - 13 of 16 passed binary check by having a zero exit code. - 0 of 16 passed binary check by having the new version present in output. - found 2.8.7 with grep in /nix/store/b5k2wcykj6s3j1rax851vpzyj6amqpvk-gdcm-2.8.7 - directory tree listing: https://gist.github.com/d4d202ac57e29b5fe6d46f1e8b7b112b - du listing: https://gist.github.com/7244757ac1449adb1adde3c480e77c8d

* treewide: http -> https sources This updates the source urls of all top-level packages from http to https where possible. * buildtorrent: fix url and tab -> spaces

Address PR comments Refactors - Rename toPLIST -> toPlist

…dtls (NixOS#41722) * mbedtls: build with cmake&ninja, clean-up * mbedtls: cmake ninja Darwin build clean-up * hiawatha: add build options, use system mbedTLS, platforms -> unix

@Mic92

Agree with @Mic92: "Since this was manually edited, we should not claim it was auto generated.

@Mic92

As per @Mic92: can be removed

@Mic92

More housecleaning, also as per @Mic92. He's right, as it says in the manual, to use fetchFromGithub instead of fetchgit > Best: Fetches a snapshot archive and you get the rev you want.

Profpatsch

You made a mistake pushing the last changes.

gavinrogers

Thanks for the very helpful review @Mic92, I've brought all these points into line. I somehow ended up getting some other code into this code review, I guess I shouldn't rebase onto master when doing code cleanup, as the PR stays on the same rev?

gavinrogers · 2018-06-28T22:38:17Z

pkgs/servers/holochain-go/default.nix

+  src = fetchgit {
+    inherit rev;
+    url = "https://github.com/holochain/holochain-proto";
+    sha256 = "19l29jnr63ximmyn4i4llv2mdwh306c2mpzmx2anj9z12wjpach0";


gavinrogers · 2018-06-28T22:38:32Z

pkgs/servers/holochain-go/default.nix

+
+buildGoPackage rec {
+  name = "holochain-go${version}";
+  version = "v0.1.0-alpha";


gavinrogers · 2018-06-28T22:39:02Z

pkgs/servers/holochain-go/default.nix

@@ -0,0 +1,31 @@
+# This file was generated by https://github.com/kamilchm/go2nix v1.2.1


Ah ok that makes sense!

gavinrogers · 2018-06-28T22:39:15Z

pkgs/servers/holochain-go/default.nix

+
+  goDeps = ./deps.nix;
+
+  # TODO: add metadata https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes


gavinrogers · 2018-07-03T20:03:06Z

#42937 Is what I've opened to replace this @Mic92 I've incorporated your feedback into commits in that PR

init: holochain-go at 0.1.0-alpha

6d92b95

Holochain is a platform for creating an unenclosable carrier upon which highly-scalable dApps and smart contracts can be built. This is the holochain team's initial implimentation in go. A rust version is under development.

Mic92 reviewed Jun 28, 2018

View reviewed changes

matthewbauer and others added 25 commits June 28, 2018 23:34

generators: add PLIST handling

61a2ca1

/cc @LnL7 @3noch

xcbuild: rework to use lib.PLIST

0dd3350

This is a good way to test that plist works. Sorry for the large diff. There are a bunch of cleanups in here that needed to be done. Should make it possible to use in cross compilation.

unixtools: add killall

0a67e52

treewide: use killall

e9a7286

feedgnuplot: init at 1.49

ddba8f7

feedgnuplot: install shell completions

09c9ded

feedgnuplot: disable tests

06602ce

lit: 0.5.1 -> 0.6.0

9d8eb27

libcCrossChooser: fix xcode eval

eca1dee

it should be targetPackages.darwin.iosSdkPkgs.libraries

xcode: default to 8.2

e9f98b1

There is some weird issue with 9.4 that needs to be resolved. 8.2 is used by iOS anyway so that makes it easier.

generators: refactor toPLIST

ede3d4b

tor-browser-bundle-bin: 7.5.5 -> 7.5.6

50910ea

treewide: http -> https sources (NixOS#42676)

b11e487

* treewide: http -> https sources This updates the source urls of all top-level packages from http to https where possible. * buildtorrent: fix url and tab -> spaces

lxd: also needs ebtables

dad5b00

generators: refactor toPlist

b521724

Address PR comments Refactors - Rename toPLIST -> toPlist

libcCross: Use correct libSystem

fe08471

mbedtls: cmake&ninja, threading, clean-up; hiawatha: options, Nix mbe…

ea7284c

…dtls (NixOS#41722) * mbedtls: build with cmake&ninja, clean-up * mbedtls: cmake ninja Darwin build clean-up * hiawatha: add build options, use system mbedTLS, platforms -> unix

nodePackages: regenerate with node2nix 1.6.0

7fd8dda

lf: 5 -> 6

3df9320

Cleanup: remove autogenerated line

45901c2

Agree with @Mic92: "Since this was manually edited, we should not claim it was auto generated.

Cleanup: remove line left over from template

23660e3

As per @Mic92: can be removed

Cleanup: remove v from version and use fetchFromGithub

c2f41fd

More housecleaning, also as per @Mic92. He's right, as it says in the manual, to use fetchFromGithub instead of fetchgit > Best: Fetches a snapshot archive and you get the rev you want.

gavinrogers requested review from edolstra, nbp, peti and Profpatsch as code owners June 28, 2018 22:34

Fix: Capitalisation of downloadPage

0b705f2

Profpatsch requested changes Jun 28, 2018

View reviewed changes

GrahamcOfBorg added the 6.topic: printing label Jun 28, 2018

gavinrogers commented Jun 28, 2018

View reviewed changes

Mic92 removed request for peti, edolstra and nbp June 28, 2018 22:45

gavinrogers closed this Jul 3, 2018

gavinrogers deleted the add-holochain branch August 1, 2018 16:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

init: holochain-go at 0.1.0-alpha #42725

init: holochain-go at 0.1.0-alpha #42725

gavinrogers commented Jun 28, 2018

Mic92 Jun 28, 2018

gavinrogers Jun 28, 2018

Mic92 Jun 28, 2018

gavinrogers Jun 28, 2018

Mic92 Jun 28, 2018

gavinrogers Jun 28, 2018

Mic92 Jun 28, 2018

gavinrogers Jun 28, 2018

Profpatsch left a comment

gavinrogers left a comment

gavinrogers Jun 28, 2018

gavinrogers Jun 28, 2018

gavinrogers Jun 28, 2018

gavinrogers Jun 28, 2018

gavinrogers commented Jul 3, 2018


		goDeps = ./deps.nix;

		# TODO: add metadata https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

		@@ -0,0 +1,31 @@
		# This file was generated by https://github.com/kamilchm/go2nix v1.2.1

init: holochain-go at 0.1.0-alpha #42725

init: holochain-go at 0.1.0-alpha #42725

Conversation

gavinrogers commented Jun 28, 2018

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Profpatsch left a comment

Choose a reason for hiding this comment

gavinrogers left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gavinrogers commented Jul 3, 2018