yubikey-manager: 0.4.0 -> 0.7.0 #42728

mkaito · 2018-06-28T14:10:14Z

Motivation for this change

0.4.0 is over a year old and doesn't work correctly.

Things done

Depends on the fido2 library, packaged in a separate commit for convenient cherry picking.

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

FRidh · 2018-06-28T17:20:06Z

pkgs/development/python-modules/fido2/default.nix

+buildPythonPackage rec {
+  pname = "fido2";
+  version = "0.3.0";
+  name = "${pname}-${version}";


The name attribute is added by buildPython* and should therefore be removed.

This has been addressed

dotlambda · 2018-06-29T11:22:25Z

pkgs/development/python-modules/fido2/default.nix

+  pname = "fido2";
+  version = "0.3.0";
+
+  src = fetchFromGitHub {


Please use fetchPypi: https://pypi.org/project/fido2/

The version on pypi appears to fail the test suite.

Then we can use fetchFromGitHub until Yubico/python-fido2#8 is merged.

Let's just leave doCheck = false in there instead of changing the source again.

Then please sqash the last two commits. And it would be nice if there was a comment why doCheck = false.

Done and done.

xeji · 2018-06-29T22:59:47Z

@GrahamcOfBorg build python27Packages.fido2 python36Packages.fido2 yubikey-manager

GrahamcOfBorg · 2018-06-29T23:00:53Z

Success on aarch64-linux (full log)

Attempted: python27Packages.fido2, python36Packages.fido2, yubikey-manager

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dna2wqsycapf9z7f7yn843ack6zqax58-python2.7-yubikey-manager-0.7.0
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dna2wqsycapf9z7f7yn843ack6zqax58-python2.7-yubikey-manager-0.7.0/lib  /nix/store/dna2wqsycapf9z7f7yn843ack6zqax58-python2.7-yubikey-manager-0.7.0/bin
patching script interpreter paths in /nix/store/dna2wqsycapf9z7f7yn843ack6zqax58-python2.7-yubikey-manager-0.7.0
checking for references to /build in /nix/store/dna2wqsycapf9z7f7yn843ack6zqax58-python2.7-yubikey-manager-0.7.0...
wrapping `/nix/store/dna2wqsycapf9z7f7yn843ack6zqax58-python2.7-yubikey-manager-0.7.0/bin/ykman'...
/nix/store/8ajzy9k5myrm8j2wqv3y9w9plqgma0sa-python2.7-fido2-0.3.0
/nix/store/w8z318gkijjmvyw204f9zrg98139lh2n-python3.6-fido2-0.3.0
/nix/store/dna2wqsycapf9z7f7yn843ack6zqax58-python2.7-yubikey-manager-0.7.0

GrahamcOfBorg · 2018-06-29T23:01:35Z

Success on x86_64-darwin (full log)

Attempted: python27Packages.fido2, python36Packages.fido2, yubikey-manager

Partial log (click to expand)

Successfully installed yubikey-manager-0.7.0
/private/tmp/nix-build-python2.7-yubikey-manager-0.7.0.drv-0/yubikey-manager-0.7.0
post-installation fixup
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/ay67vqqb48snddn32h6mji1dzx06hn4c-python2.7-yubikey-manager-0.7.0/lib  /nix/store/ay67vqqb48snddn32h6mji1dzx06hn4c-python2.7-yubikey-manager-0.7.0/bin
patching script interpreter paths in /nix/store/ay67vqqb48snddn32h6mji1dzx06hn4c-python2.7-yubikey-manager-0.7.0
wrapping `/nix/store/ay67vqqb48snddn32h6mji1dzx06hn4c-python2.7-yubikey-manager-0.7.0/bin/ykman'...
/nix/store/1cr591cg474968a1xk4ky5mxjhc147ar-python2.7-fido2-0.3.0
/nix/store/wk4nbfpkdafi53lbr06ylvag3r5995am-python3.6-fido2-0.3.0
/nix/store/ay67vqqb48snddn32h6mji1dzx06hn4c-python2.7-yubikey-manager-0.7.0

GrahamcOfBorg · 2018-06-29T23:06:23Z

Success on x86_64-linux (full log)

Attempted: python27Packages.fido2, python36Packages.fido2, yubikey-manager

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qsm1rwc2xnfwkbjasfcdjfjc53949imv-python2.7-yubikey-manager-0.7.0
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qsm1rwc2xnfwkbjasfcdjfjc53949imv-python2.7-yubikey-manager-0.7.0/lib  /nix/store/qsm1rwc2xnfwkbjasfcdjfjc53949imv-python2.7-yubikey-manager-0.7.0/bin
patching script interpreter paths in /nix/store/qsm1rwc2xnfwkbjasfcdjfjc53949imv-python2.7-yubikey-manager-0.7.0
checking for references to /build in /nix/store/qsm1rwc2xnfwkbjasfcdjfjc53949imv-python2.7-yubikey-manager-0.7.0...
wrapping `/nix/store/qsm1rwc2xnfwkbjasfcdjfjc53949imv-python2.7-yubikey-manager-0.7.0/bin/ykman'...
/nix/store/8dc7035syqbyg5rvf3q2lwn26d2lrsi6-python2.7-fido2-0.3.0
/nix/store/0jaasbb7l82381550d2bqggc372kkd9s-python3.6-fido2-0.3.0
/nix/store/qsm1rwc2xnfwkbjasfcdjfjc53949imv-python2.7-yubikey-manager-0.7.0

dotlambda · 2018-06-30T09:24:49Z

@GrahamcOfBorg build python27Packages.fido2 python36Packages.fido2 yubikey-manager

GrahamcOfBorg · 2018-06-30T09:25:47Z

Success on x86_64-linux (full log)

Attempted: python27Packages.fido2, python36Packages.fido2, yubikey-manager

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qsm1rwc2xnfwkbjasfcdjfjc53949imv-python2.7-yubikey-manager-0.7.0
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qsm1rwc2xnfwkbjasfcdjfjc53949imv-python2.7-yubikey-manager-0.7.0/lib  /nix/store/qsm1rwc2xnfwkbjasfcdjfjc53949imv-python2.7-yubikey-manager-0.7.0/bin
patching script interpreter paths in /nix/store/qsm1rwc2xnfwkbjasfcdjfjc53949imv-python2.7-yubikey-manager-0.7.0
checking for references to /build in /nix/store/qsm1rwc2xnfwkbjasfcdjfjc53949imv-python2.7-yubikey-manager-0.7.0...
wrapping `/nix/store/qsm1rwc2xnfwkbjasfcdjfjc53949imv-python2.7-yubikey-manager-0.7.0/bin/ykman'...
/nix/store/8dc7035syqbyg5rvf3q2lwn26d2lrsi6-python2.7-fido2-0.3.0
/nix/store/0jaasbb7l82381550d2bqggc372kkd9s-python3.6-fido2-0.3.0
/nix/store/qsm1rwc2xnfwkbjasfcdjfjc53949imv-python2.7-yubikey-manager-0.7.0

GrahamcOfBorg · 2018-06-30T09:26:00Z

Success on aarch64-linux (full log)

Attempted: python27Packages.fido2, python36Packages.fido2, yubikey-manager

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dna2wqsycapf9z7f7yn843ack6zqax58-python2.7-yubikey-manager-0.7.0
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dna2wqsycapf9z7f7yn843ack6zqax58-python2.7-yubikey-manager-0.7.0/lib  /nix/store/dna2wqsycapf9z7f7yn843ack6zqax58-python2.7-yubikey-manager-0.7.0/bin
patching script interpreter paths in /nix/store/dna2wqsycapf9z7f7yn843ack6zqax58-python2.7-yubikey-manager-0.7.0
checking for references to /build in /nix/store/dna2wqsycapf9z7f7yn843ack6zqax58-python2.7-yubikey-manager-0.7.0...
wrapping `/nix/store/dna2wqsycapf9z7f7yn843ack6zqax58-python2.7-yubikey-manager-0.7.0/bin/ykman'...
/nix/store/8ajzy9k5myrm8j2wqv3y9w9plqgma0sa-python2.7-fido2-0.3.0
/nix/store/w8z318gkijjmvyw204f9zrg98139lh2n-python3.6-fido2-0.3.0
/nix/store/dna2wqsycapf9z7f7yn843ack6zqax58-python2.7-yubikey-manager-0.7.0

mkaito requested a review from FRidh as a code owner June 28, 2018 14:10

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jun 28, 2018

FRidh requested changes Jun 28, 2018

View reviewed changes

mkaito force-pushed the update-ykman branch from 6d688ef to 2a7c423 Compare June 28, 2018 17:55

dotlambda reviewed Jun 29, 2018

View reviewed changes

yubikey-manager: 0.4.0 -> 0.7.0

5ceca49

mkaito force-pushed the update-ykman branch from 4e5e1c8 to 1ab6eab Compare June 30, 2018 09:16

python-fido2: init at 0.3.0

97e3024

mkaito force-pushed the update-ykman branch from 1ab6eab to 97e3024 Compare June 30, 2018 09:21

dotlambda merged commit 7725269 into NixOS:master Jun 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

yubikey-manager: 0.4.0 -> 0.7.0 #42728

yubikey-manager: 0.4.0 -> 0.7.0 #42728

mkaito commented Jun 28, 2018

FRidh Jun 28, 2018

mkaito Jun 30, 2018

dotlambda Jun 29, 2018

mkaito Jun 29, 2018

dotlambda Jun 29, 2018

mkaito Jun 30, 2018

dotlambda Jun 30, 2018

mkaito Jun 30, 2018

dotlambda Jun 30, 2018

xeji commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

dotlambda commented Jun 30, 2018

GrahamcOfBorg commented Jun 30, 2018

GrahamcOfBorg commented Jun 30, 2018

yubikey-manager: 0.4.0 -> 0.7.0 #42728

yubikey-manager: 0.4.0 -> 0.7.0 #42728

Conversation

mkaito commented Jun 28, 2018

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xeji commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

GrahamcOfBorg commented Jun 29, 2018

dotlambda commented Jun 30, 2018

GrahamcOfBorg commented Jun 30, 2018

GrahamcOfBorg commented Jun 30, 2018