Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bison2: Fix Darwin runtime crash #42722

Merged
merged 1 commit into from Jul 5, 2018
Merged

bison2: Fix Darwin runtime crash #42722

merged 1 commit into from Jul 5, 2018

Conversation

thefloweringash
Copy link
Member

Motivation for this change

Noticed bison2 crashes on startup on Darwin. Don't know if bison2 is significant any more.

Before:

$ nix-shell -I nixpkgs=channel:nixpkgs-unstable -p bison2 --run 'bison --version | head -1'
.../nix-shell-21482-0/rc: line 1: 22036 Abort trap: 6           bison --version

After:

$ nix-shell -I nixpkgs=. -p bison2 --run 'bison --version | head -1'
bison (GNU Bison) 2.7

Similar change to the same underlying code that caused a similar problem with cvs: e49f601

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member

dtzWill commented Jun 28, 2018

After seeing this, noticed we should probably be using 2.7.1: #42726 although I don't see anything at a glance that would suggest it helps with this, but thought I'd mention since a bit related :).

@dtzWill
Copy link
Member

dtzWill commented Jun 28, 2018

Unfortunately, since this adds a "patches" attribute --even if empty on non-darwin-- this triggers mass rebuilds (see tags the bot added). Can this be sent to staging instead?

@matthewbauer
Copy link
Member

Yeah staging is fine - might as well make it unconditional too. Make sure this issue is reported upstream though.

@Mic92
Copy link
Member

Mic92 commented Jun 28, 2018

Upstream patches would go to: bison-patches@gnu.org

@xeji xeji changed the base branch from master to staging June 30, 2018 17:12
@kirelagin
Copy link
Member

I am not even sure how Hydra managed to build it 😕. It is in the cache but when I rebuild it locally, tests fail.

@matthewbauer matthewbauer merged commit a447691 into NixOS:staging Jul 5, 2018
@thefloweringash thefloweringash deleted the bison2-darwin branch July 23, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@thefloweringash @dtzWill @matthewbauer @Mic92 @kirelagin @GrahamcOfBorg