Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 5 commits
- 8 files changed
- 1 contributor
Commits on Jun 28, 2018
-
[refactor] cleanup and review RubyIO internals
- review internals to cast less - return concrete types - non-boxing IO helpers for In/Out Java Stream wrappers - deprecate un-used over-load JRuby methods - make var-args readlines delegating to io.readlines - use helper for (small) array copy-ing - handle several (IDEA) code warnings
-
lets use AssertionError on unexpected outcomes
... managed to fool myself with a catch RuntimeException already
-
[refactor] split getline internal into 2 methods
... also removed byte-list cache handling for now - never used
-
[refactor] cleanup RubyArgsFile - prefer getx(ctx) impl
although weird getc does getbyte but specs covered, thus fine
-
[fix] exec/spawn invalid opts expected to raise ArgumentError
... and deprecate the old public static helpers on RubyIO's end
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 6598331f4f45...39d1ba335d27