Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chrony: disable the whole timesyncd module when chronyd is enabled #42365

Merged
merged 1 commit into from Jun 24, 2018
Merged

chrony: disable the whole timesyncd module when chronyd is enabled #42365

merged 1 commit into from Jun 24, 2018

Conversation

basvandijk
Copy link
Member

@basvandijk basvandijk commented Jun 22, 2018 •
edited

Peviously only the timesyncd systemd unit was disabled when you enable chrony. This meant that when you activate a system that has chronyd enabled the following strange startup behaviour takes place:

  systemd[1]: Starting chrony NTP daemon...
  systemd[1]: Stopping Network Time Synchronization...
  systemd[1]: Stopped chrony NTP daemon.
  systemd[1]: Starting Network Time Synchronization...
Motivation for this change
Things done

Tested this on my laptop by setting services.chrony.enable = true, switching the configuration and observing that timesyncd is stopped and chronyd is started.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@basvandijk
chrony: disable the whole timesyncd module when chronyd is enabled
56ef106 
Peviously only the timesyncd systemd unit was disabled. This meant
that when you activate a system that has chronyd enabled the following
strange startup behaviour takes place:

  systemd[1]: Starting chrony NTP daemon...
  systemd[1]: Stopping Network Time Synchronization...
  systemd[1]: Stopped chrony NTP daemon.
  systemd[1]: Starting Network Time Synchronization...
@basvandijk basvandijk mentioned this pull request Jun 22, 2018
Merged
infinisil
infinisil approved these changes Jun 24, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@andir
Copy link
Member

andir commented Jun 24, 2018

Thanks!
Does that also apply for 18.03? Would you consider it a bug that deserves backporting? If so, can you open PR of that?

@infinisil
Copy link
Member

@andir See #42366

@xeji xeji merged commit bbe8321 into NixOS:master Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@basvandijk @andir @infinisil @GrahamcOfBorg @xeji