Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.monty: init at 1.0.2 #42367

Merged
merged 2 commits into from Jun 23, 2018
Merged

pythonPackages.monty: init at 1.0.2 #42367

merged 2 commits into from Jun 23, 2018

Conversation

PsyanticY
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@PsyanticY PsyanticY requested a review from FRidh as a code owner June 22, 2018 11:55
pSub
pSub requested changes Jun 22, 2018
View reviewed changes
pkgs/development/python-modules/monty/default.nix
--replace 'self.assertIs(which("non_existent_exe"), None)' '#' \
'';

meta = with stdenv.lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a short description (in field description), too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pSub Done.

@FRidh
Copy link
Member

FRidh commented Jun 23, 2018

@GrahamcOfBorg build pythonPackages.monty python3Packages.monty

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.monty, python3Packages.monty

Partial log (click to expand)

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
        1    0.000    0.000    0.000    0.000 {built-in method builtins.exec}
        1    0.000    0.000    0.000    0.000 test_functools.py:715(main)
        1    0.000    0.000    0.000    0.000 <string>:1(<module>)
        1    0.000    0.000    0.000    0.000 {method 'disable' of '_lsprof.Profiler' objects}
        1    0.000    0.000    0.000    0.000 {built-in method sys.exit}


/nix/store/g8i3a1hkmd2jb86qb47aqdxy1srlc3zv-python2.7-monty-1.0.2
/nix/store/7bk8bixvnaavz3cnz24gc5pvn5b19qcr-python3.6-monty-1.0.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.monty, python3Packages.monty

Partial log (click to expand)

        1    0.000    0.000    0.000    0.000 {built-in method builtins.exec}
        1    0.000    0.000    0.000    0.000 test_functools.py:715(main)
        1    0.000    0.000    0.000    0.000 <string>:1(<module>)
        1    0.000    0.000    0.000    0.000 {method 'disable' of '_lsprof.Profiler' objects}
        1    0.000    0.000    0.000    0.000 {built-in method sys.exit}


command: ['sleep', '0.5'], retcode: 0
/nix/store/1w3hy92fqyylgqm3ynw6afxl7wrn61xz-python2.7-monty-1.0.2
/nix/store/kbqvq99b7wyni69mldbqbqz7h9qvqkkd-python3.6-monty-1.0.2

@FRidh FRidh merged commit 4df1161 into NixOS:master Jun 23, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pythonPackages.monty, python3Packages.monty

Partial log (click to expand)

�[8m�[5m�[2m�[37mDark blink concealed white color�[0m
------------------------------------------------------------------------------
Test mixing:
�[4m�[40m�[31mUnderline red on grey color�[0m
�[7m�[41m�[32mReversed green on red color�[0m
�[31mHello�[0m world
�[41m�[34mHello�[0m world
terminal size: %s (25, 80)
/nix/store/pr0vsg35gbqxwiaw4vq511njvxafz0rn-python2.7-monty-1.0.2
/nix/store/rzd0sx6rb1avilnh2qwjagsjskwj5mqi-python3.6-monty-1.0.2

@PsyanticY PsyanticY deleted the monty branch June 25, 2018 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PsyanticY @FRidh @GrahamcOfBorg @pSub