Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry sending failed notifications every 3 minutes, fixes #565. #566

Closed
wants to merge 2 commits into from

Conversation

benhamad
Copy link

No description provided.

@edolstra
Copy link
Member

This doesn't seem right to me, since it might enqueue NotificationItems for a build/step every 3 minutes, even if that build/step is already in the notificationSenderQueue.

I think a better approach would be to, in the State::notificationSender() exception handler, to put the item back in the queue (up to a limited number of retries). When the number of retries is exceeded, the notificationPendingSince field should be cleared in the database to prevent it being retries when hydra-queue-runner is restarted.

If we reach 3 retries, ignore it by clearing notificationPendingSince
column in the database.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants