Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnirehtet: init at 2.2.1 #42373

Merged
merged 1 commit into from Jun 22, 2018
Merged

gnirehtet: init at 2.2.1 #42373

merged 1 commit into from Jun 22, 2018

Conversation

symphorien
Copy link
Member

Motivation for this change

Fixes #35515

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@symphorien symphorien mentioned this pull request Jun 22, 2018
Closed
jtojnar
jtojnar reviewed Jun 22, 2018
View reviewed changes
pkgs/tools/networking/gnirehtet/default.nix Outdated
cargoSha256 = "11qf9n6h6akvb0rbmsgdlfmypkbnas8ss1cs7i8w19mh7524n0v5";

patchPhase = ''
substituteInPlace src/main.rs \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to use an actual patch file (through substituteAll) so it is noticed when the substitution no longer works.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@jtojnar
Copy link
Contributor

jtojnar commented Jun 22, 2018

Thanks. Looks great, even though it does not work for me due to Genymobile/gnirehtet#117

@jtojnar jtojnar merged commit 876598a into NixOS:master Jun 22, 2018
@symphorien symphorien deleted the gnirehtet branch June 22, 2018 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@symphorien @jtojnar @GrahamcOfBorg