Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qutebrowser: 1.3.2 -> 1.3.3 #42364

Merged
merged 1 commit into from Jun 22, 2018
Merged

qutebrowser: 1.3.2 -> 1.3.3 #42364

merged 1 commit into from Jun 22, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

https://blog.qutebrowser.org/qutebrowser-v133-released-security-update.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jun 22, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: qutebrowser

Partial log (click to expand)

/nix/store/zy8nzkia4v0asx1hcf5dcka7zm121f0l-qutebrowser-1.3.3/share/qutebrowser/userscripts/tor_identity: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/yxzy33fw61kj9ljk30i5qyjrv3pax0kc-python3-3.6.5/bin/python3"
/nix/store/zy8nzkia4v0asx1hcf5dcka7zm121f0l-qutebrowser-1.3.3/share/qutebrowser/userscripts/view_in_mpv: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/bash"
/nix/store/zy8nzkia4v0asx1hcf5dcka7zm121f0l-qutebrowser-1.3.3/share/qutebrowser/scripts/importer.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/yxzy33fw61kj9ljk30i5qyjrv3pax0kc-python3-3.6.5/bin/python3"
/nix/store/zy8nzkia4v0asx1hcf5dcka7zm121f0l-qutebrowser-1.3.3/share/qutebrowser/scripts/dictcli.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/yxzy33fw61kj9ljk30i5qyjrv3pax0kc-python3-3.6.5/bin/python3"
/nix/store/zy8nzkia4v0asx1hcf5dcka7zm121f0l-qutebrowser-1.3.3/share/qutebrowser/scripts/keytester.py: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/yxzy33fw61kj9ljk30i5qyjrv3pax0kc-python3-3.6.5/bin/python3"
/nix/store/zy8nzkia4v0asx1hcf5dcka7zm121f0l-qutebrowser-1.3.3/share/qutebrowser/scripts/open_url_in_instance.sh: interpreter directive changed from "/bin/bash" to "/nix/store/0aa1ngxygf1iqanfbpdb10klc7r343c0-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/zy8nzkia4v0asx1hcf5dcka7zm121f0l-qutebrowser-1.3.3...
wrapping `/nix/store/zy8nzkia4v0asx1hcf5dcka7zm121f0l-qutebrowser-1.3.3/bin/.qutebrowser-wrapped'...
postPatchMkspecs
/nix/store/zy8nzkia4v0asx1hcf5dcka7zm121f0l-qutebrowser-1.3.3

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: qutebrowser

Partial log (click to expand)

[6769/16620] CXX obj/third_party/webrtc/modules/rtp_rtcp/rtp_rtcp/flexfec_header_reader_writer.o
[6770/16620] CXX obj/third_party/webrtc/modules/video_coding/video_coding/nack_module.o
[6771/16620] CXX obj/third_party/webrtc/modules/congestion_controller/estimators/trendline_estimator.o
[6772/16620] CXX obj/third_party/webrtc/modules/pacing/pacing/packet_queue2.o
[6773/16620] CXX obj/third_party/webrtc/modules/rtp_rtcp/rtp_rtcp/rtp_sender_video.o
[6774/16620] CXX obj/third_party/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator/remote_estimator_proxy.o
building of '/nix/store/v1jmzby10v585sg6sn8gqxpzyqwidgar-qtwebengine-5.11.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/pc7ys1mmz518nmgbx8fcc9yap7nv6kdd-python3.6-PyQt-5.10.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/p8g1wrvzrzgb67qj7p3lq37l549q6jjq-qutebrowser-1.3.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/p8g1wrvzrzgb67qj7p3lq37l549q6jjq-qutebrowser-1.3.3.drv' failed

@lsix lsix merged commit 7587917 into NixOS:master Jun 22, 2018
@lsix
Copy link
Member

lsix commented Jun 22, 2018

I have built it locally, ran nox-review pr and tested it.

Thanks.

@dotlambda will you cherry-pick the change to release-18.03 or do I do it ?

@dotlambda
Copy link
Member Author

Please do it. I only have access to my phone right now.

@lsix
Copy link
Member

lsix commented Jun 22, 2018

Pushed to release-18.03 as 91b286c

@dotlambda dotlambda deleted the qutebrowser-1.3.3 branch March 21, 2019 09:33
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dotlambda @GrahamcOfBorg @lsix @garrett-hopper @samueldr