libvirtd build: drop support for tmpfs during image build
#974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Note*: caution, this patch breaks the compatibility with NixOS 17.09 and should only be used in unstable branches. Originally NixOS/nixpkgs@0d27df2 dropped support for `tempfs` which broke the libvirtd image build as it still created custom kernel nodes. These `mkdnod` calls were wrapped by conditionls to keep support with 17.09, but now as 17.09 is the oldstable release which only receives security fixes (https://groups.google.com/forum/#!msg/nix-devel/7bRK8FUcC5s/CV4-i0JdBgAJ), so it's time to drop this compliance hacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: caution, this patch breaks the compatibility with NixOS 17.09 and
should only be used in unstable branches.
Originally NixOS/nixpkgs@0d27df2
dropped support for
tempfswhich broke the libvirtd image build as itstill created custom kernel nodes.
These
mkdnodcalls were wrapped by conditionls to keep support with 17.09,but now as 17.09 is the oldstable release which only receives security
fixes (https://groups.google.com/forum/#!msg/nix-devel/7bRK8FUcC5s/CV4-i0JdBgAJ),
so it's time to drop this compliance hacks.