Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kmod-blacklist-ubuntu: Fix typo from commit "do not blacklist i2c_i801" #42787

Merged
merged 1 commit into from Jul 16, 2018
Merged

kmod-blacklist-ubuntu: Fix typo from commit "do not blacklist i2c_i801" #42787

merged 1 commit into from Jul 16, 2018

Conversation

ambrop72
Copy link
Contributor

That commit did not actually accomplish its intent because it misspelled the module name.

I did not verify that this fixes any real issue but I am sending this fix after noticing the mistake incidentally. I have verified that after this fix /etc/modprobe.d/ubuntu.conf does not have that blacklist line while it did before.

Should probably be backported to 18.03.

Motivation for this change

Typo in module name.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ambrop72
kmod-blacklist-ubuntu: Fix typo from commit "do not blacklist i2c_i801"
0ed43b5 
That commit did not actually accomplish its intent because it misspelled the module name.
@joachifm joachifm requested a review from peterhoeg July 2, 2018 23:56
@peterhoeg
Copy link
Member

It looks like the original commit was a mistake (in addition to the typo) as i2c_i801 is loading correctly for me despite being blacklisted:

peter@mildred:~ $ grep i801 /etc/modprobe.d/ubuntu.conf                                                                                                                              ~
blacklist i2c_i801
peter@mildred:~ $ lsmod | grep i801                                                                                                                                                  ~
i2c_i801               32768  0
i2c_core               73728  9 videodev,i2c_hid,drm_kms_helper,i2c_algo_bit,i2c_i801,i915,psmouse,i2c_dev,drm

Strange...

@peterhoeg
Copy link
Member

In any case, this PR is doing the right thing.

@peterhoeg peterhoeg merged commit 6c44deb into NixOS:master Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ambrop72 @peterhoeg @GrahamcOfBorg