Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librepcb-unstable: 2017-12-29 -> 2018-06-28 #42786

Merged
merged 4 commits into from Jun 30, 2018
Merged

librepcb-unstable: 2017-12-29 -> 2018-06-28 #42786

merged 4 commits into from Jun 30, 2018

Conversation

Luz
Copy link
Contributor

@Luz Luz commented Jun 29, 2018

Motivation for this change

A newer version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Luz Luz changed the title Librepcb: 20171229 -> 20180628 Librepcb-unstable: 2017-12-29 -> 2018-06-28 Jun 29, 2018
@Luz Luz changed the title Librepcb-unstable: 2017-12-29 -> 2018-06-28 librepcb-unstable: 2017-12-29 -> 2018-06-28 Jun 29, 2018
xeji
xeji reviewed Jun 29, 2018
View reviewed changes
pkgs/top-level/all-packages.nix Outdated
@@ -20569,7 +20569,7 @@ with pkgs;
boost = boost160;
};

librepcb = libsForQt5.callPackage ../applications/science/electronics/librepcb { };
librepcb = libsForQt59.callPackage ../applications/science/electronics/librepcb { };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it necessary to use the older qt 5.9 instead of the current default 5.11 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the input!
I just tried 5.11 and it works too.

@xeji
Copy link
Contributor

xeji commented Jun 30, 2018

@GrahamcOfBorg build librepcb

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: librepcb

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: librepcb

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9r9zg7f8r5zwzh7rnff5hzljsz8l9z8v-librepcb-20180628
shrinking /nix/store/9r9zg7f8r5zwzh7rnff5hzljsz8l9z8v-librepcb-20180628/bin/librepcb
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9r9zg7f8r5zwzh7rnff5hzljsz8l9z8v-librepcb-20180628/bin
patching script interpreter paths in /nix/store/9r9zg7f8r5zwzh7rnff5hzljsz8l9z8v-librepcb-20180628
checking for references to /build in /nix/store/9r9zg7f8r5zwzh7rnff5hzljsz8l9z8v-librepcb-20180628...
postPatchMkspecs
postPatchMkspecs
/nix/store/9r9zg7f8r5zwzh7rnff5hzljsz8l9z8v-librepcb-20180628

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: librepcb

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/drma9m3ynl2027wj410f3cbz2sacxjcj-librepcb-20180628
shrinking /nix/store/drma9m3ynl2027wj410f3cbz2sacxjcj-librepcb-20180628/bin/librepcb
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/drma9m3ynl2027wj410f3cbz2sacxjcj-librepcb-20180628/bin
patching script interpreter paths in /nix/store/drma9m3ynl2027wj410f3cbz2sacxjcj-librepcb-20180628
checking for references to /build in /nix/store/drma9m3ynl2027wj410f3cbz2sacxjcj-librepcb-20180628...
postPatchMkspecs
postPatchMkspecs
/nix/store/drma9m3ynl2027wj410f3cbz2sacxjcj-librepcb-20180628

@xeji xeji merged commit f6a2869 into NixOS:master Jun 30, 2018
@Luz Luz deleted the librepcb branch July 1, 2018 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Luz @xeji @GrahamcOfBorg