Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.tensorflow-tensorboard: 1.7.0 -> 1.9.0 #42783

Closed
wants to merge 2 commits into from
Closed

python.pkgs.tensorflow-tensorboard: 1.7.0 -> 1.9.0 #42783

wants to merge 2 commits into from

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jun 29, 2018 •
edited

Motivation for this change

Tensorboard now ships a vendored version of bleach, so we can get rid of python.pkgs.bleach_1_5_0: tensorflow/tensorboard#1142

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from FRidh as a code owner June 29, 2018 18:21
Robert Schütz added 2 commits July 2, 2018 00:29
python.pkgs.tensorflow-tensorboard: 1.7.0 -> 1.9.0
efa0ef1
python.pkgs.bleach_1_5_0: remove
9a0ec5f 
python.pkgs.html5lib_0_9999999 can now be removed as well
@dotlambda
Copy link
Member Author

It seems like this breaks the build of tensorflow (Python 3 seems fine however):
@GrahamcOfBorg build python2.pkgs.tensorflow
cc @abbradar @jyp

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.tensorflow

Partial log (click to expand)

unpacking sources
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
building
installing
/build/dist /build
tensorflow-1.7.1-cp27-none-linux_x86_64.whl is not a supported wheel on this platform.
builder for '/nix/store/h82pz7w63ib6kxk3yjxy78ywkl2hkk7p-python2.7-tensorflow-1.7.1.drv' failed with exit code 1
error: build of '/nix/store/h82pz7w63ib6kxk3yjxy78ywkl2hkk7p-python2.7-tensorflow-1.7.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python2.pkgs.tensorflow

Partial log (click to expand)

Requirement already satisfied: mock>=2.0.0 in /nix/store/bpqqimy6i2q4ps04mnqicvz7zccn34cd-python2.7-mock-2.0.0/lib/python2.7/site-packages (from tensorflow==1.7.1) (2.0.0)
Requirement already satisfied: enum34>=1.1.6 in /nix/store/ikzm75zqzjvzkfqjsgny638ga1zr8x3y-python2.7-enum34-1.1.6/lib/python2.7/site-packages (from tensorflow==1.7.1) (1.1.6)
Requirement already satisfied: gast>=0.2.0 in /nix/store/2yqp7byfs58qrz9z3cpyjljmi1wnfch6-python2.7-gast-0.2.0/lib/python2.7/site-packages (from tensorflow==1.7.1) (0.2.0)
Requirement already satisfied: termcolor>=1.1.0 in /nix/store/fswzglngx3ihaj2miwbq1zy2syvxjfxy-python2.7-termcolor-1.1.0/lib/python2.7/site-packages (from tensorflow==1.7.1) (1.1.0)
Requirement already satisfied: absl-py>=0.1.6 in /nix/store/5nn7gr22vyj6dz3cgzb87s1mz9wws7ss-python2.7-absl-py-0.2.2/lib/python2.7/site-packages (from tensorflow==1.7.1) (0.2.2)
Collecting tensorboard<1.8.0,>=1.7.0 (from tensorflow==1.7.1)
  Could not find a version that satisfies the requirement tensorboard<1.8.0,>=1.7.0 (from tensorflow==1.7.1) (from versions: )
No matching distribution found for tensorboard<1.8.0,>=1.7.0 (from tensorflow==1.7.1)
builder for '/nix/store/029fl74hflk6ikf5adflrs9vhh691qln-python2.7-tensorflow-1.7.1.drv' failed with exit code 1
error: build of '/nix/store/029fl74hflk6ikf5adflrs9vhh691qln-python2.7-tensorflow-1.7.1.drv' failed

@dotlambda
Copy link
Member Author

@GrahamcOfBorg build python3.pkgs.tensorflow

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python3.pkgs.tensorflow

Partial log (click to expand)

unpacking sources
patching sources
updateAutotoolsGnuConfigScriptsPhase
configuring
building
installing
/build/dist /build
tensorflow-1.7.1-cp36-cp36m-linux_x86_64.whl is not a supported wheel on this platform.
builder for '/nix/store/yapgfz86c1sg647aa1b56l8yp9dvkgl7-python3.6-tensorflow-1.7.1.drv' failed with exit code 1
error: build of '/nix/store/yapgfz86c1sg647aa1b56l8yp9dvkgl7-python3.6-tensorflow-1.7.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python3.pkgs.tensorflow

Partial log (click to expand)

copying path '/nix/store/l0l33zklj96683r596nbwdlk8wdfry82-python3.6-absl-py-0.2.2' from 'https://cache.nixos.org'...
copying path '/nix/store/xq6g9kvg4k6a5vima2jn76bi1cmlsirj-python3.6-astor-0.6.2' from 'https://cache.nixos.org'...
copying path '/nix/store/z3ki6wnng8pds082nwjgg09xkwh0vzxm-python3.6-gast-0.2.0' from 'https://cache.nixos.org'...
copying path '/nix/store/xvpd78lziqw0y58n5l1panzpywbcln8d-python3.6-mox-0.5.3' from 'https://cache.nixos.org'...
copying path '/nix/store/wb550dad5krmpsa7gkc80y3jyz0r3njw-python3.6-python-gflags-3.1.2' from 'https://cache.nixos.org'...
copying path '/nix/store/yl1jag0j1y7vxf50b2sh38h957nw15q0-python3.6-numpy-1.14.5' from 'https://cache.nixos.org'...
copying path '/nix/store/cr4lc2wli2l484d1xxfcs7lqk4nfhyiv-python3.6-google-apputils-0.4.1' from 'https://cache.nixos.org'...
copying path '/nix/store/rcddmmis6756dw9pq0iw3iid8nk7pyqp-python3.6-protobuf-3.5.1.1' from 'https://cache.nixos.org'...
copying path '/nix/store/5zlvhajsq0qxp138hknca4wc32ygn26w-python3.6-tensorflow-1.7.1' from 'https://cache.nixos.org'...
/nix/store/5zlvhajsq0qxp138hknca4wc32ygn26w-python3.6-tensorflow-1.7.1

@jyp
Copy link
Contributor

jyp commented Jul 4, 2018

@dotlambda Note that the tensorflow build for most recent python does not check dependencies, precisely because of the bleach issue. So this may explain why "python3 is fine".

Presumably though, you will need to upgrade the version of tensorflow at the same time as tensorboard to keep it happy. I see that the current version is 1.9.0-rc2 --- why not wait until 1.9.0 is out and try then with consistent versions?

@dotlambda
Copy link
Member Author

@jyp Tensorflow 1.9.0 has been released in the meantime. Would you mind updating it and including my commits?

@jyp
Copy link
Contributor

jyp commented Aug 1, 2018

@dotlambda I tried to update to tensorflow 1.9.0, but unfortunately it does not work. It has a dependency on setuptools <=39.1.0. But, apparently, setuptools has a special status and we can't install an older version along the current one. I am out of ideas.

@jyp jyp mentioned this pull request Aug 1, 2018
Closed
@dotlambda dotlambda mentioned this pull request Aug 6, 2018
Closed
@jyp jyp mentioned this pull request Aug 7, 2018
Merged
9 tasks
@dotlambda
Copy link
Member Author

included in #44599

@dotlambda dotlambda closed this Aug 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @GrahamcOfBorg @jyp