Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree-wide: users.extraUsers -> users.users, users.extraGroups -> users.groups #42798

Merged
merged 4 commits into from Jul 2, 2018
Merged

tree-wide: users.extraUsers -> users.users, users.extraGroups -> users.groups #42798

merged 4 commits into from Jul 2, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jun 30, 2018 •
edited

Motivation for this change

Followup of #42746, now replacing usages of users.extraUsers and users.extraGroups with users.users and users.groups.

This is more than a quick search/replace, as there's valid uses for extraGroups (either as option in other modules or as users.users.<name?>.extraGroups, so please have a very cautious look.
I did run some tests on my machine, but can't run all.

/cc @volth, @xeji

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

infinisil
infinisil approved these changes Jul 1, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through all replacements, all good

@flokli
Copy link
Contributor Author

flokli commented Jul 2, 2018

@infinisil thanks for the review! Are you comfortable merging it then? ;-)

@infinisil
Copy link
Member

Sorry I don't have merge rights :). Approval hook gray: reviewer can't merge; approval hook green: reviewer can merge

I mostly leave the reviews so people with merge rights have it easier and know that another pair of eyes has taken a look

@7c6f434c 7c6f434c merged commit b43c4d8 into NixOS:master Jul 2, 2018
@7c6f434c
Copy link
Member

7c6f434c commented Jul 2, 2018

@infinisil then again, if you asked for merge rights now, I am pretty sure you would get them.

@infinisil
Copy link
Member

@7c6f434c I actually just asked @edolstra yesterday via IRC, haven't gotten a response yet though :) (sneaky ping)

@7c6f434c
Copy link
Member

7c6f434c commented Jul 2, 2018

Often asking @rbvermaa gets a faster reaction on such requests.

@flokli flokli deleted the users-users branch July 2, 2018 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flokli @infinisil @7c6f434c @GrahamcOfBorg