Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php71: 7.1.18 -> 7.1.19 #42558

Merged
merged 1 commit into from Jun 25, 2018
Merged

php71: 7.1.18 -> 7.1.19 #42558

merged 1 commit into from Jun 25, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Jun 25, 2018 •
edited

Motivation for this change

Changelog: https://secure.php.net/ChangeLog-7.php#7.1.19

Since it's a PHP minor version I'd say it's worth backporting this change to stable channel.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: php71

Partial log (click to expand)

/nix/store/bqkri8ilhpgvsn6hrb95filhllrjgaqr-php-7.1.19/lib/build/config.guess: interpreter directive changed from " /bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/bqkri8ilhpgvsn6hrb95filhllrjgaqr-php-7.1.19/lib/build/shtool: interpreter directive changed from "/bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
/nix/store/bqkri8ilhpgvsn6hrb95filhllrjgaqr-php-7.1.19/lib/build/config.sub: interpreter directive changed from " /bin/sh" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/bqkri8ilhpgvsn6hrb95filhllrjgaqr-php-7.1.19...
moving /nix/store/bqkri8ilhpgvsn6hrb95filhllrjgaqr-php-7.1.19/sbin/* to /nix/store/bqkri8ilhpgvsn6hrb95filhllrjgaqr-php-7.1.19/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/9c89zh67va9w8manf44vqclka8pws78z-php-7.1.19-dev
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/9c89zh67va9w8manf44vqclka8pws78z-php-7.1.19-dev
checking for references to /build in /nix/store/9c89zh67va9w8manf44vqclka8pws78z-php-7.1.19-dev...
/nix/store/bqkri8ilhpgvsn6hrb95filhllrjgaqr-php-7.1.19

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: php71

Partial log (click to expand)

/nix/store/dibpmhswvpkna8lcsm1vm8qx1qgx8xj7-php-7.1.19/bin/pear: interpreter directive changed from "/bin/sh" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/sh"
/nix/store/dibpmhswvpkna8lcsm1vm8qx1qgx8xj7-php-7.1.19/bin/php-config: interpreter directive changed from " /bin/sh" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/sh"
/nix/store/dibpmhswvpkna8lcsm1vm8qx1qgx8xj7-php-7.1.19/bin/phpize: interpreter directive changed from "/bin/sh" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/dibpmhswvpkna8lcsm1vm8qx1qgx8xj7-php-7.1.19...
moving /nix/store/dibpmhswvpkna8lcsm1vm8qx1qgx8xj7-php-7.1.19/sbin/* to /nix/store/dibpmhswvpkna8lcsm1vm8qx1qgx8xj7-php-7.1.19/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/wbyyhvdg5s16sal3y5mx6b5ny4kgsnsw-php-7.1.19-dev
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/wbyyhvdg5s16sal3y5mx6b5ny4kgsnsw-php-7.1.19-dev
checking for references to /build in /nix/store/wbyyhvdg5s16sal3y5mx6b5ny4kgsnsw-php-7.1.19-dev...
/nix/store/dibpmhswvpkna8lcsm1vm8qx1qgx8xj7-php-7.1.19

@xeji xeji merged commit e0208b9 into NixOS:master Jun 25, 2018
@xeji
Copy link
Contributor

xeji commented Jun 25, 2018

backported in 18abd86 and b3f42ae

@etu etu deleted the php-update branch June 25, 2018 11:22
@etu
Copy link
Contributor Author

etu commented Jun 25, 2018

@xeji Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@etu @GrahamcOfBorg @xeji