Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/ceph: ensure services are started, allow osd to access devices #42560

Closed
wants to merge 2 commits into from
Closed

nixos/ceph: ensure services are started, allow osd to access devices #42560

wants to merge 2 commits into from

Conversation

krav
Copy link
Contributor

@krav krav commented Jun 25, 2018

Motivation for this change

ceph daemons are not started on boot, additionally osd needs access to disks. This sets systemd dependencies and disables privateDevices for osd.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@krav
Copy link
Contributor Author

krav commented Jun 26, 2018

Disregard, will make a larger pull request of ceph fixes later.

@krav krav closed this Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krav @GrahamcOfBorg