pHash: init at 0.9.4 #42546
Merged
pHash: init at 0.9.4 #42546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb55
suggested changes
Jun 27, 2018
maintainers/maintainer-list.nix
Outdated
| @@ -1717,6 +1717,11 @@ | |||
| github = "ilya-kolpakov"; | |||
| name = "Ilya Kolpakov"; | |||
| }; | |||
| imalsogreg = { | |||
| src = fetchFromGitHub { | ||
| owner = "clearscene"; | ||
| repo = "pHash"; | ||
| rev = "0.9.4"; |
|
|
||
| meta = { | ||
| inherit version; | ||
| description = ''Compute the perceptual hash of an image''; |
There was a problem hiding this comment.
nit: '' '' is for multi-line string, you can just use "Compute the perceptual hash of an image" here
| sha256 = "0y4gknfkns5sssfaj0snyx29752my20xmxajg6xggijx0myabbv0"; | ||
| }; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
style nit: common pattern is to do:
meta = with stdenv.lib; { }
so you don't have to fully qualify everything in the meta
GrahamcOfBorg
added
2.status: merge conflict
and removed
2.status: merge conflict
labels
|
@jb55 Thank you for the pointers! I've made those changes and rebased on master. |
jb55
approved these changes
Jun 27, 2018
jb55
suggested changes
Jun 27, 2018
| meta = with stdenv.lib; { | ||
| inherit version; | ||
| description = "Compute the perceptual hash of an image"; | ||
| license = icenses.gpl3; |
Fix style and redundancy issues pointed out by @jb55
|
@jb55 Hah, how embarrassing. I assumed the meta fields are checked by |
|
@GrahamcOfBorg build phash |
|
Success on x86_64-linux (full log) Attempted: phash Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: phash Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: phash Partial log (click to expand)
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
pHashis a useful c library with several small quirks in its build process and increasing numbers of workarounds for building on other systems.We also have
phashHaskell bindings innixpkgswhich is broken due to lack of packaging of the c library.Things done
NixOS, or option
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/) (N/A)nix path-info -Sbefore and after)Additional testing
C
Wrote a small c program depending on
pHashwhich passes a CLI argument to the library and prints the hash. This works on NixOS and Darwin.Haskell
The
phashHaskell library with modifications to the cabal file, to usepkgconfig-dependsfield. This doesn't quite work out of the box, for reasons I am still trying to understand (and which may be due to problems withpHash, my nix packaging,cabal, orpkg-config, or any combination of the above). I can get the library to compile only if I add a second fakepkg-configdependency (I choselibzmqrandomly). With two entries inpkgconfig-dependsfield, thephashbindings can successfully hash an image from a filepath. However when using only the true dependency,configurephase fails: