Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1password: fix sha256 hash #42539

Merged
merged 2 commits into from Jun 25, 2018
Merged

1password: fix sha256 hash #42539

merged 2 commits into from Jun 25, 2018

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jun 24, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji xeji merged commit be9240b into NixOS:master Jun 25, 2018
@jb55
Copy link
Contributor

jb55 commented Jun 25, 2018

uhh since this is a password manager, was there any investigation as to why the hash was changed?

@grahamc
Copy link
Member

grahamc commented Jun 25, 2018

@xeji did you test this change prior to merging? I'm surprised nobody called ofborg.

@xeji
Copy link
Contributor

xeji commented Jun 25, 2018 via email

@xeji
Copy link
Contributor

xeji commented Jun 25, 2018 via email

@jb55
Copy link
Contributor

jb55 commented Jun 25, 2018

I've verified the new hashes, the binaries are signed with the op signing key: https://keybase.io/1password

Please confirm that this has been done before merging, for future hash changes!

Thanks :)

@xeji xeji mentioned this pull request Jun 25, 2018
Closed
9 tasks
@xeji
Copy link
Contributor

xeji commented Jun 25, 2018

@jb55 checking code signatures manually before merging would be a pain since each tarball needs to be unpacked first. It makes more sense to check the signature automatically during build.
I give that a try in #42580.

@marsam marsam deleted the feature/1password-fix-hash branch June 25, 2018 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marsam @jb55 @grahamc @xeji @GrahamcOfBorg