lief: init at 0.9.0 #42565
Merged
lief: init at 0.9.0 #42565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success on x86_64-darwin (full log) Attempted: lief Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: lief Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: lief Partial log (click to expand)
|
xeji
suggested changes
Jun 25, 2018
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: lief Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: lief Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: lief Partial log (click to expand)
|
xeji
reviewed
Jun 26, 2018
| license = [ licenses.asl20 ]; | ||
| platforms = platforms.linux; | ||
| maintainers = [ maintainers.lassulus ]; | ||
| }; |
There was a problem hiding this comment.
meta belongs outside the fetchzip, not in it.
There was a problem hiding this comment.
This use is definitely okay. fetchzip output can be installed as a normal derivation so it is pretty much needed to use meta here. I also much prefer it to the all too common cp -r $src/* $out because it will be fixed output.
There was a problem hiding this comment.
Sorry, didn't know about that. Never seen this use before.
xeji
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://lief.quarkslab.com/
For now I just use the released version because I couldn't get the cmake build to work, as it wants to do something with git I couldn't figure out.