Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.re: 1.7.1 -> 1.7.3 #42551

Merged
merged 2 commits into from Jun 26, 2018
Merged

ocamlPackages.re: 1.7.1 -> 1.7.3 #42551

merged 2 commits into from Jun 26, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jun 25, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 25, 2018

@GrahamcOfBorg build ocamlPackages.re ocamlPackages.bap libbap

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: ocamlPackages.re, ocamlPackages.bap, libbap

Partial log (click to expand)

findlib: [WARNING] Interface topdirs.cmi occurs in several directories: /nix/store/bgjl5hg5jgx2s5shw32gjkwg2z894z46-ocaml-4.06.1/lib/ocaml/compiler-libs, /nix/store/bgjl5hg5jgx2s5shw32gjkwg2z894z46-ocaml-4.06.1/lib/ocaml
File "src/lib/uTop.cppo.ml", line 152, characters 22-79:
Error: Some record fields are undefined: out_indent
Command exited with code 2.
E: Failure("Command ''/nix/store/b6qr4p56ls54dhd8d531vay6ci12d4xp-ocamlbuild-0.12.0/bin/ocamlbuild' src/lib/utop.cma src/lib/utop.cmxa src/lib/utop.a src/lib/utop.cmxs src/camlp4/utop-camlp4.cma src/camlp4/utop-camlp4.cmxa src/camlp4/utop-camlp4.a src/camlp4/utop-camlp4.cmxs src/top/uTop_top.byte src/top/uTop_top_full.byte -use-ocamlfind -plugin-tags 'package(cppo_ocamlbuild)' -tag debug' terminated with error code 10")
make: *** [Makefile:27: build] Error 1
builder for '/nix/store/ffivb6frlnyr94zwb8if9460si79id0k-utop-1.19.3.drv' failed with exit code 2
cannot build derivation '/nix/store/76mr6p2rv33v4gpa4vzvrdp1lpwngfz9-ocaml4.06.1-bap-1.4.0.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/7i7z8749fxhlaq8p2hawcx8a1h1vjsnz-libbap-master-2018-03-01.drv': 1 dependencies couldn't be built
error: build of '/nix/store/76mr6p2rv33v4gpa4vzvrdp1lpwngfz9-ocaml4.06.1-bap-1.4.0.drv', '/nix/store/7i7z8749fxhlaq8p2hawcx8a1h1vjsnz-libbap-master-2018-03-01.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ocamlPackages.re, ocamlPackages.bap, libbap

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/29pmh1yrg335h3679ic94qgw1w7i75ma-libbap-master-2018-03-01
shrinking /nix/store/29pmh1yrg335h3679ic94qgw1w7i75ma-libbap-master-2018-03-01/lib/libbap.so
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/29pmh1yrg335h3679ic94qgw1w7i75ma-libbap-master-2018-03-01/lib
patching script interpreter paths in /nix/store/29pmh1yrg335h3679ic94qgw1w7i75ma-libbap-master-2018-03-01
checking for references to /build in /nix/store/29pmh1yrg335h3679ic94qgw1w7i75ma-libbap-master-2018-03-01...
/nix/store/96klkfzfqg20y2rj3pl69vs45ybhl1z5-ocaml4.05.0-re-1.7.3
/nix/store/ywlkn5s650wj2mkabkmky56qkvi2q3vx-ocaml4.05.0-bap-1.4.0
/nix/store/29pmh1yrg335h3679ic94qgw1w7i75ma-libbap-master-2018-03-01

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: ocamlPackages.re, ocamlPackages.bap, libbap

Partial log (click to expand)

Installed /nix/store/zjcfkbnh4kpm794wpc5llg4dmhsnjsgs-utop-1.19.3/lib/ocaml/4.05.0/site-lib/utop/uTop_camlp4.cmti
Installed /nix/store/zjcfkbnh4kpm794wpc5llg4dmhsnjsgs-utop-1.19.3/lib/ocaml/4.05.0/site-lib/utop/uTop_camlp4.cmt
Installed /nix/store/zjcfkbnh4kpm794wpc5llg4dmhsnjsgs-utop-1.19.3/lib/ocaml/4.05.0/site-lib/utop/uTop_camlp4.annot
Installed /nix/store/zjcfkbnh4kpm794wpc5llg4dmhsnjsgs-utop-1.19.3/lib/ocaml/4.05.0/site-lib/utop/META
post-installation fixup
gzipping man pages under /nix/store/zjcfkbnh4kpm794wpc5llg4dmhsnjsgs-utop-1.19.3/share/man/
patching script interpreter paths in /nix/store/zjcfkbnh4kpm794wpc5llg4dmhsnjsgs-utop-1.19.3
cannot build derivation '/nix/store/2jhfcyp5jjxzbhswwbwk48v8gdd9hab5-ocaml4.05.0-bap-1.4.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/4v127vklshm3nxxawpnyba6xbf99h4dm-libbap-master-2018-03-01.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/2jhfcyp5jjxzbhswwbwk48v8gdd9hab5-ocaml4.05.0-bap-1.4.0.drv', '/nix/store/4v127vklshm3nxxawpnyba6xbf99h4dm-libbap-master-2018-03-01.drv' failed

@xeji
Copy link
Contributor

xeji commented Jun 25, 2018

libbap did build on darwin without this PR, see https://hydra.nixos.org/job/nixpkgs/trunk/libbap.x86_64-darwin.

@vbgl
Copy link
Contributor Author

vbgl commented Jun 25, 2018

And it still does, right?

@xeji
Copy link
Contributor

xeji commented Jun 25, 2018

According to https://hydra.nixos.org/jobset/nixpkgs/trunk/jobs-tab?filter=libbap.x86_64-darwin
the last successful darwin build of libbap was 2 days ago. Newer builds are still queued, so we don't know their result yet.

@xeji
Copy link
Contributor

xeji commented Jun 25, 2018

But after looking at the log of the failed darwin build above, the original failure is in llvm_38 which is a dependency of bap so it is probably not related to this PR.

@xeji xeji merged commit 9c5b6bb into NixOS:master Jun 26, 2018
@vbgl vbgl deleted the ocaml-re-1.7.3 branch June 26, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @xeji @GrahamcOfBorg