Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILLUSIONS: New engine. Duckman support #1229

Merged
merged 214 commits into from Jul 20, 2018
Merged

ILLUSIONS: New engine. Duckman support #1229

merged 214 commits into from Jul 20, 2018

Conversation

yuv422
Copy link
Member

@yuv422 yuv422 commented Jun 25, 2018

Hi,

I've fixed up the Duckman Illusions engine. The game is now complete-able with all major features included. English + German versions are supported.

I now believe it is ready to merge to master.

Note. I haven't done any work on "Beavis and Butthead Do U" It is still experimental.

- Add fixed point code (untested and probably wrong)
- Add isTimerExpired function
yuv422 and others added 23 commits July 6, 2018 22:35
(cherry picked from commit 3367aaf)

ILLUSIONS: Delete dictionary list before it gets removed

(cherry picked from commit d9d0c11)

ILLUSIONS: Implement PathFinder::postProcess

(cherry picked from commit ee98dfc)
(cherry picked from commit 32c2a9b)
(cherry picked from commit bb95440)
(cherry picked from commit 9abaa9e)
(cherry picked from commit 66094e4)
@yuv422
Copy link
Member Author

yuv422 commented Jul 6, 2018

I've squashed the non compiling commits. They should all compile now. :)

@bonki
Copy link
Member

bonki commented Jul 6, 2018

Thanks! Unfortunately the history is still a mess because the engine hasn't been rebased continuously on top of master which results in many commits still failing to compile (among other things this is especially a pain when bisecting).

I have now tried cleaning this up by cherry-picking all non-merge commits touching engines/illusions/ since commit
3d91c85 (oldest commit in your PR) into a new branch on top of master. I fixed the commit messages not following our guidelines and then interactively rebased and stepped through every single commit making sure all necessary changes to make every commit compile propagate properly.

Something along the lines of (this is from memory):

$ git checkout yumv422/illusions
$ git rev-list 3d91c85^..HEAD -- engines/illusions >/tmp/illusions.commits
$ git checkout master
$ git checkout -b bonki-illusions-cleanup
$ xargs -n 1 git cherry-pick < <(tac /tmp/illusions.commits)
$ git rebase -i 3d91c85^
(s#pick#edit#g)
$ while make -j6 && git add . && git commit --amend --no-edit && git rebase --continue; do :; done
(fix stuff)
$ git diff yuv422/illusions -- engines/illusions
(no diff, yay)

This resides in bonki/bonki-illusions-cleanup.

I hope someone can confirm that I didn't do anything silly and the result is as expected.

@yuv422
Copy link
Member Author

yuv422 commented Jul 9, 2018

@bonki
Your branch looks good to me. :)

@dafioram
Copy link
Contributor

So the next step is to merge bonki/bonki-illusions-cleanup into master?

@bonki
Copy link
Member

bonki commented Jul 19, 2018

I'm happy to merge, especially since @johndoe123's recent changes have been merged since and nobody has objected in quite a while. OK @sev-?

@sev- sev- merged commit 848b5a5 into scummvm:master Jul 20, 2018
@sev-
Copy link
Member

sev- commented Jul 20, 2018

Merged, and added @yuv422 to the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants