Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvirt: enable (optional) support for iscsi storage #42545

Merged
merged 1 commit into from Jun 25, 2018
Merged

libvirt: enable (optional) support for iscsi storage #42545

merged 1 commit into from Jun 25, 2018

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jun 25, 2018

Motivation for this change

I use this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Jun 25, 2018

@GrahamcOfBorg build libvirt

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: libvirt

Partial log (click to expand)

these paths will be fetched (6.24 MiB download, 34.76 MiB unpacked):
  /nix/store/ajkdaz6smy603gci6wj5qs4hlf11pb8h-libvirt-4.4.0
  /nix/store/q2ksd9f9lrszmxg9jzfrnh0whp4znv6k-dnsmasq-2.78
  /nix/store/vwqv3ly0q3szq2z76hbqh444z6aw2ww4-yajl-2.1.0
copying path '/nix/store/q2ksd9f9lrszmxg9jzfrnh0whp4znv6k-dnsmasq-2.78' from 'https://cache.nixos.org'...
copying path '/nix/store/vwqv3ly0q3szq2z76hbqh444z6aw2ww4-yajl-2.1.0' from 'https://cache.nixos.org'...
copying path '/nix/store/ajkdaz6smy603gci6wj5qs4hlf11pb8h-libvirt-4.4.0' from 'https://cache.nixos.org'...
/nix/store/ajkdaz6smy603gci6wj5qs4hlf11pb8h-libvirt-4.4.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: libvirt

Partial log (click to expand)

/nix/store/ycf4fz52d0xv37lgxizpv7nyk33ya39b-libvirt-4.4.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: libvirt

Partial log (click to expand)

copying path '/nix/store/bngimkid0mqqqiz8pjfp9b6ly337h76z-kerberos-env-1.15.2' from 'https://cache.nixos.org'...
copying path '/nix/store/q7m2xd1rf8q5vl6nd2pkmsqg01jnz0vq-libnfsidmap-0.25' from 'https://cache.nixos.org'...
copying path '/nix/store/rvhs53v1f2rc0kdd06lblbzhm1d5wjn1-libtirpc-1.0.3' from 'https://cache.nixos.org'...
copying path '/nix/store/i079603y4vshczp5yw3hjkklygfslmzl-libnsl-1.1.0' from 'https://cache.nixos.org'...
copying path '/nix/store/y3izndjjdlcq1mw9nqh7f891plax02dk-tcp-wrappers-7.6.q-26' from 'https://cache.nixos.org'...
copying path '/nix/store/0pgifx6piw2d36kk5ya7ywa3bz2sssfx-nfs-utils-2.1.1' from 'https://cache.nixos.org'...
copying path '/nix/store/ca7aw82hrqjrx9jnrh27k9g2827ck2wi-zfs-user-0.7.9-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/ab6mh62lg7r91wg48dzrh83y7cylrwi1-zfs-user-0.7.9' from 'https://cache.nixos.org'...
copying path '/nix/store/n38hmfncjsf75rxbz7h1ib0k9l02xfcm-libvirt-4.4.0' from 'https://cache.nixos.org'...
/nix/store/n38hmfncjsf75rxbz7h1ib0k9l02xfcm-libvirt-4.4.0

@xeji xeji merged commit 2cd0c2e into NixOS:master Jun 25, 2018
@ajs124 ajs124 mentioned this pull request Jun 27, 2018
Merged
9 tasks
ajs124 added a commit to ajs124/nixpkgs that referenced this pull request Jun 27, 2018
@ajs124
libvirt: fix iscsi storage support
3f9d968 
Turns out, I was testing NixOS#42545 in a nix-shell and forgot how it handles dependencies different from environments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @xeji @GrahamcOfBorg