Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init targetcli and dependencies for lio iscsi target management #42543

Merged
merged 3 commits into from Nov 26, 2018
Merged

init targetcli and dependencies for lio iscsi target management #42543

merged 3 commits into from Nov 26, 2018

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jun 24, 2018

Motivation for this change

The LIO iscsi target is (relatively) widely used and packaged in a lot of distributions. That and I happen to use it, myself.

It might be noteworthy, that these packages all use the "-fb" branch, meaning the open-iscsi version and not the old, seemingly unmaintained versions. Some distributions still append this suffix, for some reason.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 requested a review from FRidh as a code owner June 24, 2018 23:34
FRidh
FRidh requested changes Jun 25, 2018
View reviewed changes
pkgs/development/python-modules/configshell/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/configshell/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/rtslib/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/targetcli/default.nix Show resolved Hide resolved
pkgs/os-specific/linux/targetcli/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/targetcli/default.nix Outdated Show resolved Hide resolved
@ajs124 ajs124 force-pushed the targetcli branch 2 times, most recently from bf1833d to 903add6 Compare June 25, 2018 09:37
@ajs124
Copy link
Member Author

ajs124 commented Jul 21, 2018

ping @FRidh

@dasJ
Copy link
Member

dasJ commented Sep 22, 2018

@FRidh What is the state of this? It seems like all points were resolved.

@FRidh
Copy link
Member

FRidh commented Sep 23, 2018

@ajs124 are you going to maintain these packages?

@ajs124
Copy link
Member Author

ajs124 commented Sep 23, 2018

Sure, should I add myself as the maintainer?

@kalbasit
Copy link
Member

is this PR still relevant? @ajs124 would you like to update the PR and get it ready for merging?

@ajs124
Copy link
Member Author

ajs124 commented Nov 26, 2018

@kalbasit what's there to update? I just rebased on top of master, but I think I already addressed all issues.

@kalbasit
Copy link
Member

@GrahamcOfBorg build python27Packages.configshell python27Packages.rtslib python37Packages.configshell python37Packages.rtslib targetcli

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python27Packages.configshell, python27Packages.rtslib, python37Packages.configshell, python37Packages.rtslib, targetcli

Partial log (click to expand)


----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/ar8z1fdc3h91hnqjfacqjdhsawrjnx99-python2.7-configshell-1.1.fb25
/nix/store/76m11mbwn6wfqn7rbd2rrkpjmsf925wh-python2.7-rtslib-2.1.fb69
/nix/store/x4spylwch6as8q2n6jy82nqw04dzlw8i-python3.7-configshell-1.1.fb25
/nix/store/zlw0q3dbd31l6c9clhvyd5hgwx7sa6n2-python3.7-rtslib-2.1.fb69
/nix/store/q6bhd8s76mcx3qhrc36mqf90z6ss3rnp-targetcli-2.1.fb49

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python27Packages.configshell, python27Packages.rtslib, python37Packages.configshell, python37Packages.rtslib, targetcli

Partial log (click to expand)


----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/bdz7x5bvbmz87ydw0riamsgmsrzhwz09-python2.7-configshell-1.1.fb25
/nix/store/3v16za76zm84fz8dn2rq00djnblrhvna-python2.7-rtslib-2.1.fb69
/nix/store/y5k9h4in9is3yq0zn6153n5k75mnbdkx-python3.7-configshell-1.1.fb25
/nix/store/j8fpmas33m522qsqd817qks1fxfn2pdh-python3.7-rtslib-2.1.fb69
/nix/store/95qx5p29lw36ngy2q5ikwwjgby5vqris-targetcli-2.1.fb49

@kalbasit kalbasit merged commit 5294194 into NixOS:master Nov 26, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: python27Packages.configshell, python37Packages.configshell

The following builds were skipped because they don't evaluate on x86_64-darwin: python27Packages.rtslib, python37Packages.rtslib, targetcli

Partial log (click to expand)

running build_ext
/nix/store/yzdxaqyjpiygbaxb91nb723ghxa7f8fz-python3-3.7.1/lib/python3.7/unittest/loader.py:375: UserWarning: 'configshell' package name for configshell-fb is deprecated, please instead import 'configshell_fb'
  __import__(name)

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/zvykqzj17zqi9nn4rz9mqnzxv7vjk7xl-python2.7-configshell-1.1.fb25
/nix/store/zjkychznqfazwnfcmgi4hw3q1c8i9ig8-python3.7-configshell-1.1.fb25

@ajs124 ajs124 deleted the targetcli branch January 4, 2019 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ajs124 @dasJ @FRidh @kalbasit @GrahamcOfBorg