Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul-alerts: 0.3.3 -> 0.5.0 #42542

Merged
merged 2 commits into from Jun 25, 2018
Merged

consul-alerts: 0.3.3 -> 0.5.0 #42542

merged 2 commits into from Jun 25, 2018

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jun 24, 2018

Motivation for this change

Newer version with nice performance fixes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@nlewo
Copy link
Member

nlewo commented Jun 25, 2018

@GrahamcOfBorg build consul-alerts

@nh2 I know this is out of this PR, but it would be nice to add the meta attribute. Would you like to become the maintener of this package? In this case, could you add yourself in the meta of this package?

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: consul-alerts

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/2giyc53xk02vl73ry0asgfrgyjsl9l77-consul-alerts-0.5.0-bin/bin
patching script interpreter paths in /nix/store/2giyc53xk02vl73ry0asgfrgyjsl9l77-consul-alerts-0.5.0-bin
checking for references to /build in /nix/store/2giyc53xk02vl73ry0asgfrgyjsl9l77-consul-alerts-0.5.0-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/g4lahrqjqgh312zmdn324lgmj7g1jy1r-consul-alerts-0.5.0
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/g4lahrqjqgh312zmdn324lgmj7g1jy1r-consul-alerts-0.5.0
/nix/store/g4lahrqjqgh312zmdn324lgmj7g1jy1r-consul-alerts-0.5.0/share/go/src/github.com/AcalephStorage/consul-alerts/.buildkite: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
/nix/store/g4lahrqjqgh312zmdn324lgmj7g1jy1r-consul-alerts-0.5.0/share/go/src/github.com/AcalephStorage/consul-alerts/.buildkite-release: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/p0vy17dp9jk2mvqsxsqnb14s3797lay7-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/g4lahrqjqgh312zmdn324lgmj7g1jy1r-consul-alerts-0.5.0...
/nix/store/2giyc53xk02vl73ry0asgfrgyjsl9l77-consul-alerts-0.5.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: consul-alerts

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/z9a6g9scvqs76z6cv0clsqwhg3bq85rj-consul-alerts-0.5.0-bin/bin
patching script interpreter paths in /nix/store/z9a6g9scvqs76z6cv0clsqwhg3bq85rj-consul-alerts-0.5.0-bin
checking for references to /build in /nix/store/z9a6g9scvqs76z6cv0clsqwhg3bq85rj-consul-alerts-0.5.0-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/77vgv2p8lmhak4nfg3mg9vqznz797g69-consul-alerts-0.5.0
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/77vgv2p8lmhak4nfg3mg9vqznz797g69-consul-alerts-0.5.0
/nix/store/77vgv2p8lmhak4nfg3mg9vqznz797g69-consul-alerts-0.5.0/share/go/src/github.com/AcalephStorage/consul-alerts/.buildkite-release: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/77vgv2p8lmhak4nfg3mg9vqznz797g69-consul-alerts-0.5.0/share/go/src/github.com/AcalephStorage/consul-alerts/.buildkite: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/77vgv2p8lmhak4nfg3mg9vqznz797g69-consul-alerts-0.5.0...
/nix/store/z9a6g9scvqs76z6cv0clsqwhg3bq85rj-consul-alerts-0.5.0-bin

@nh2
Copy link
Contributor Author

nh2 commented Jun 25, 2018

@nh2 I know this is out of this PR, but it would be nice to add the meta attribute. Would you like to become the maintener of this package? In this case, could you add yourself in the meta of this package?

@nlewo OK, I'm happy to take on maintainer role for this package at least for a while; I've pushed a commit to add a meta that reflects that.

@nlewo
Copy link
Member

nlewo commented Jun 25, 2018

@nh2 cool, thanks!

@nlewo nlewo merged commit 580f9d7 into NixOS:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nh2 @nlewo @GrahamcOfBorg