Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

casync: init at 2-152-ge4a3c5e #42541

Merged
merged 4 commits into from Jun 25, 2018
Merged

casync: init at 2-152-ge4a3c5e #42541

merged 4 commits into from Jun 25, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jun 24, 2018 •
edited

Motivation for this change

This adds casync to nixpkgs, with their tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@flokli flokli mentioned this pull request Jun 24, 2018
Closed
@jtojnar
Copy link
Contributor

jtojnar commented Jun 24, 2018

You probably need to patchShebangs build/test-script.sh in postPatch (it has /bin/bash in shebang).

@jtojnar
Copy link
Contributor

jtojnar commented Jun 24, 2018

Actually test/test-script.sh.in

@flokli
Copy link
Contributor Author

flokli commented Jun 24, 2018

That did the trick, thanks!

@flokli flokli changed the title WIP: casync: init at 2-152-ge4a3c5e casync: init at 2-152-ge4a3c5e Jun 25, 2018
@flokli
Copy link
Contributor Author

flokli commented Jun 25, 2018

updated PR to set PKG_CONFIG_UDEV_UDEVDIR instead of applying the patch.
We already do exactly the same in pkgs/tools/misc/colord/default.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: casync

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: casync

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/15bvxcj009bn5nficnvwhnp2s6kjcd5x-casync-2-152-ge4a3c5e
shrinking /nix/store/15bvxcj009bn5nficnvwhnp2s6kjcd5x-casync-2-152-ge4a3c5e/bin/casync
shrinking /nix/store/15bvxcj009bn5nficnvwhnp2s6kjcd5x-casync-2-152-ge4a3c5e/lib/casync/protocols/casync-http
gzipping man pages under /nix/store/15bvxcj009bn5nficnvwhnp2s6kjcd5x-casync-2-152-ge4a3c5e/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/15bvxcj009bn5nficnvwhnp2s6kjcd5x-casync-2-152-ge4a3c5e/lib  /nix/store/15bvxcj009bn5nficnvwhnp2s6kjcd5x-casync-2-152-ge4a3c5e/bin
patching script interpreter paths in /nix/store/15bvxcj009bn5nficnvwhnp2s6kjcd5x-casync-2-152-ge4a3c5e
checking for references to /build in /nix/store/15bvxcj009bn5nficnvwhnp2s6kjcd5x-casync-2-152-ge4a3c5e...
/nix/store/15bvxcj009bn5nficnvwhnp2s6kjcd5x-casync-2-152-ge4a3c5e

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: casync

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lg3vk14pk7kwcw44qfz09xb9lkarq3jd-casync-2-152-ge4a3c5e
shrinking /nix/store/lg3vk14pk7kwcw44qfz09xb9lkarq3jd-casync-2-152-ge4a3c5e/lib/casync/protocols/casync-http
shrinking /nix/store/lg3vk14pk7kwcw44qfz09xb9lkarq3jd-casync-2-152-ge4a3c5e/bin/casync
gzipping man pages under /nix/store/lg3vk14pk7kwcw44qfz09xb9lkarq3jd-casync-2-152-ge4a3c5e/share/man/
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lg3vk14pk7kwcw44qfz09xb9lkarq3jd-casync-2-152-ge4a3c5e/lib  /nix/store/lg3vk14pk7kwcw44qfz09xb9lkarq3jd-casync-2-152-ge4a3c5e/bin
patching script interpreter paths in /nix/store/lg3vk14pk7kwcw44qfz09xb9lkarq3jd-casync-2-152-ge4a3c5e
checking for references to /build in /nix/store/lg3vk14pk7kwcw44qfz09xb9lkarq3jd-casync-2-152-ge4a3c5e...
/nix/store/lg3vk14pk7kwcw44qfz09xb9lkarq3jd-casync-2-152-ge4a3c5e

@xeji xeji merged commit 104194f into NixOS:master Jun 25, 2018
@flokli flokli deleted the casync branch June 25, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flokli @jtojnar @GrahamcOfBorg @xeji